diff mbox

[testsuite] Fix fragile case nsdmi-union5

Message ID 000001cf5ac7$1ac58de0$5050a9a0$@arm.com
State New
Headers show

Commit Message

Joey Ye April 18, 2014, 5:28 a.m. UTC 
Resulting from discussion here:
http://gcc.gnu.org/ml/gcc/2014-04/msg00125.html

ChangeLog:
	* g++.dg/cpp0x/nsdmi-union5.C: Change to runtime test.

Comments

Mike Stump April 21, 2014, 3:38 p.m. UTC | #1 
On Apr 17, 2014, at 10:28 PM, Joey Ye <joey.ye@arm.com> wrote:
> Resulting from discussion here:
> http://gcc.gnu.org/ml/gcc/2014-04/msg00125.html

Not checked in, and no Ok? asked…  You should do one or the other…  :-)  I’ll assume Ok?

Ok.

> ChangeLog:
> 	* g++.dg/cpp0x/nsdmi-union5.C: Change to runtime test.
> 
> Index: gcc/testsuite/g++.dg/cpp0x/nsdmi-union5.C
> ===================================================================
> --- gcc/testsuite/g++.dg/cpp0x/nsdmi-union5.C	(revision 209462)
> +++ gcc/testsuite/g++.dg/cpp0x/nsdmi-union5.C	(working copy)
> @@ -1,6 +1,5 @@
> // PR c++/58701
> -// { dg-require-effective-target c++11 }
> -// { dg-final { scan-assembler "7" } }
> +// { dg-do run { target c++11 } }
> 
> static union
> {
> @@ -9,3 +8,10 @@
>     int i = 7;
>   };
> };
> +
> +extern "C" void abort(void);
> +int main()
> +{
> +  if (i != 7) abort();
> +  return 0;
> +}
Joey Ye April 24, 2014, 8:25 a.m. UTC | #2 
> -----Original Message-----
> From: Mike Stump [mailto:mikestump@comcast.net]
> Sent: Monday, April 21, 2014 11:39 PM
> To: Joey Ye
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [patch, testsuite] Fix fragile case nsdmi-union5
> 
> On Apr 17, 2014, at 10:28 PM, Joey Ye <joey.ye@arm.com> wrote:
> > Resulting from discussion here:
> > http://gcc.gnu.org/ml/gcc/2014-04/msg00125.html
> 
> Not checked in, and no Ok? asked.  You should do one or the other.  :-)
I'll
> assume Ok?
> 
> Ok.
Just committed.
diff mbox

Patch

Index: gcc/testsuite/g++.dg/cpp0x/nsdmi-union5.C
===================================================================
--- gcc/testsuite/g++.dg/cpp0x/nsdmi-union5.C	(revision 209462)
+++ gcc/testsuite/g++.dg/cpp0x/nsdmi-union5.C	(working copy)
@@ -1,6 +1,5 @@ 
 // PR c++/58701
-// { dg-require-effective-target c++11 }
-// { dg-final { scan-assembler "7" } }
+// { dg-do run { target c++11 } }
 
 static union
 {
@@ -9,3 +8,10 @@ 
     int i = 7;
   };
 };
+
+extern "C" void abort(void);
+int main()
+{
+  if (i != 7) abort();
+  return 0;
+}