| Message ID | 20230608033642.4097956-1-xu.yang_2@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format | expand |
On 08/06/2023 05:36, Xu Yang wrote: > Convert the binding to DT schema format. Besides, this also add other > optional properties not contained in txt file. Why ones do you add? > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v2: > - change filename to fsl,mxs-usbphy.yaml > - add other optional properties > - narrow fsl,anatop to imx6 > - use additionalProperties > --- > .../bindings/phy/fsl,mxs-usbphy.yaml | 128 ++++++++++++++++++ > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 ----- > 2 files changed, 128 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > new file mode 100644 > index 000000000000..1b6b19fdf491 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > @@ -0,0 +1,128 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale MXS USB Phy Device > + > +maintainers: > + - Xu Yang <xu.yang_2@nxp.com> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx23-usbphy > + - fsl,vf610-usbphy > + - fsl,imx7ulp-usbphy Keep the list sorted. > + - items: > + - enum: > + - fsl,imx28-usbphy > + - fsl,imx6ul-usbphy > + - fsl,imx6sl-usbphy > + - fsl,imx6sx-usbphy > + - fsl,imx6q-usbphy > + - const: fsl,imx23-usbphy > + - items: > + - const: fsl,imx6sll-usbphy > + - const: fsl,imx6ul-usbphy > + - const: fsl,imx23-usbphy > + - items: > + - const: fsl,imx7ulp-usbphy > + - const: fsl,imx6ul-usbphy > + - items: > + - const: fsl,imx8dxl-usbphy > + - const: fsl,imx7ulp-usbphy > + > + reg: > + minItems: 1 > + maxItems: 2 You should list the items. > + > + interrupts: > + minItems: 1 > + maxItems: 2 You should list the items. > + > + clocks: > + maxItems: 1 > + > + '#phy-cells': > + const: 0 > + > + power-domains: > + maxItems: 1 > + > + fsl,anatop: > + description: > + phandle for anatop register, it is only for imx6 SoC series. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + phy-3p0-supply: > + description: > + One of USB PHY's power supply. Can be used to keep a good signal > + quality. > + > + fsl,tx-cal-45-dn-ohms: > + description: > + Resistance (in ohms) of switchable high-speed trimming resistor > + connected in parallel with the 45 ohm resistor that terminates > + the DN output signal. > + minimum: 35 > + maximum: 54 > + default: 45 > + > + fsl,tx-cal-45-dp-ohms: > + description: > + Resistance (in ohms) of switchable high-speed trimming resistor > + connected in parallel with the 45 ohm resistor that terminates > + the DP output signal. > + minimum: 35 > + maximum: 54 > + default: 45 > + > + fsl,tx-d-cal: > + description: > + Current trimming value (as a percentage) of the 17.78 mA TX > + reference current. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 79 > + maximum: 119 > + default: 100 > + > +required: > + - compatible > + - reg > + - clocks > + > +allOf: > + - if: > + properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx6sl-usbphy It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. > + - fsl,imx6sx-usbphy > + - fsl,imx6sll-usbphy > + - fsl,imx6q-usbphy > + - fsl,vf610-usbphy > + - items: > + - const: fsl,imx6ul-usbphy > + - const: fsl,imx23-usbphy > + then: > + required: > + - fsl,anatop > + > +additionalProperties: false > + Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Saturday, June 10, 2023 12:44 AM > To: Xu Yang <xu.yang_2@nxp.com>; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org > Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux- > imx@nxp.com>; linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > usb@vger.kernel.org; Jun Li <jun.li@nxp.com> > Subject: [EXT] Re: [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format > > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the > message using the 'Report this email' button > > > On 08/06/2023 05:36, Xu Yang wrote: > > Convert the binding to DT schema format. Besides, this also add other > > optional properties not contained in txt file. > > Why ones do you add? I add clock, power-domains and phy-3p0-supply to this doc. Because the txt file should contain these properties but it not. I think the txt doesn't get update in time. > > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > --- > > Changes in v2: > > - change filename to fsl,mxs-usbphy.yaml > > - add other optional properties > > - narrow fsl,anatop to imx6 > > - use additionalProperties > > --- > > .../bindings/phy/fsl,mxs-usbphy.yaml | 128 ++++++++++++++++++ > > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 ----- > > 2 files changed, 128 insertions(+), 33 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt > > > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > new file mode 100644 > > index 000000000000..1b6b19fdf491 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > @@ -0,0 +1,128 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > http://devicetree.org/schemas/phy/fsl,mxs- > usbphy.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Ccdb34e27fd17419bbe3608db6908b13d%7C686ea1d3bc2b4 > c6fa92cd99c5c301635%7C0%7C0%7C638219258284008643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj > oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4pNCtSE9x4kENZsGf2nq%2F2S8uazubTjeqpSZ > XyRRVOo%3D&reserved=0 > > +$schema: http://devicetree.org/meta- > schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Ccdb34e27fd17419bbe3608db6908b13d%7C686ea > 1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638219258284008643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM > DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QjXo%2FzS6Ntl2RGBScVJfkdIONo6Sa > psDkcDM5AY9cgQ%3D&reserved=0 > > + > > +title: Freescale MXS USB Phy Device > > + > > +maintainers: > > + - Xu Yang <xu.yang_2@nxp.com> > > + > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - fsl,imx23-usbphy > > + - fsl,vf610-usbphy > > + - fsl,imx7ulp-usbphy > > Keep the list sorted. Okay. > > > + - items: > > + - enum: > > + - fsl,imx28-usbphy > > + - fsl,imx6ul-usbphy > > + - fsl,imx6sl-usbphy > > + - fsl,imx6sx-usbphy > > + - fsl,imx6q-usbphy > > + - const: fsl,imx23-usbphy > > + - items: > > + - const: fsl,imx6sll-usbphy > > + - const: fsl,imx6ul-usbphy > > + - const: fsl,imx23-usbphy > > + - items: > > + - const: fsl,imx7ulp-usbphy > > + - const: fsl,imx6ul-usbphy > > + - items: > > + - const: fsl,imx8dxl-usbphy > > + - const: fsl,imx7ulp-usbphy > > + > > + reg: > > + minItems: 1 > > + maxItems: 2 > > You should list the items. > > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > You should list the items. After my check, the maxItems value of reg and interrupts should be 1. Will change it. > > > + > > + clocks: > > + maxItems: 1 > > + > > + '#phy-cells': > > + const: 0 > > + > > + power-domains: > > + maxItems: 1 > > + > > + fsl,anatop: > > + description: > > + phandle for anatop register, it is only for imx6 SoC series. > > + $ref: /schemas/types.yaml#/definitions/phandle > > + > > + phy-3p0-supply: > > + description: > > + One of USB PHY's power supply. Can be used to keep a good signal > > + quality. > > + > > + fsl,tx-cal-45-dn-ohms: > > + description: > > + Resistance (in ohms) of switchable high-speed trimming resistor > > + connected in parallel with the 45 ohm resistor that terminates > > + the DN output signal. > > + minimum: 35 > > + maximum: 54 > > + default: 45 > > + > > + fsl,tx-cal-45-dp-ohms: > > + description: > > + Resistance (in ohms) of switchable high-speed trimming resistor > > + connected in parallel with the 45 ohm resistor that terminates > > + the DP output signal. > > + minimum: 35 > > + maximum: 54 > > + default: 45 > > + > > + fsl,tx-d-cal: > > + description: > > + Current trimming value (as a percentage) of the 17.78 mA TX > > + reference current. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 79 > > + maximum: 119 > > + default: 100 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + oneOf: > > + - enum: > > + - fsl,imx6sl-usbphy > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. Missed this in v2, but already checked bindings in v3. However, I have checked schema using dt-doc-validate and dtbs using dt-validate tools. > > > + - fsl,imx6sx-usbphy > > + - fsl,imx6sll-usbphy > > + - fsl,imx6q-usbphy > > + - fsl,vf610-usbphy > > + - items: > > + - const: fsl,imx6ul-usbphy > > + - const: fsl,imx23-usbphy > > + then: > > + required: > > + - fsl,anatop > > + > > +additionalProperties: false > > + > > > Best regards, > Krzysztof Thanks, Xu Yang
On 13/06/2023 09:30, Xu Yang wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Saturday, June 10, 2023 12:44 AM >> To: Xu Yang <xu.yang_2@nxp.com>; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org >> Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux- >> imx@nxp.com>; linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >> usb@vger.kernel.org; Jun Li <jun.li@nxp.com> >> Subject: [EXT] Re: [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format >> >> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the >> message using the 'Report this email' button >> >> >> On 08/06/2023 05:36, Xu Yang wrote: >>> Convert the binding to DT schema format. Besides, this also add other >>> optional properties not contained in txt file. >> >> Why ones do you add? > > I add clock, power-domains and phy-3p0-supply to this doc. Because > the txt file should contain these properties but it not. I think the > txt doesn't get update in time. Can you mention them in commit msg? > >>> + reg: >>> + minItems: 1 >>> + maxItems: 2 >> >> You should list the items. >> >>> + >>> + interrupts: >>> + minItems: 1 >>> + maxItems: 2 >> >> You should list the items. > > After my check, the maxItems value of reg and interrupts should be 1. > Will change it. OK Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, June 13, 2023 3:40 PM > To: Xu Yang <xu.yang_2@nxp.com>; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org > Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux- > imx@nxp.com>; linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > usb@vger.kernel.org; Jun Li <jun.li@nxp.com> > Subject: Re: [EXT] Re: [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format > > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the > message using the 'Report this email' button > > > On 13/06/2023 09:30, Xu Yang wrote: > > Hi Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Saturday, June 10, 2023 12:44 AM > >> To: Xu Yang <xu.yang_2@nxp.com>; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org > >> Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > <linux- > >> imx@nxp.com>; linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux- > >> usb@vger.kernel.org; Jun Li <jun.li@nxp.com> > >> Subject: [EXT] Re: [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format > >> > >> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report > the > >> message using the 'Report this email' button > >> > >> > >> On 08/06/2023 05:36, Xu Yang wrote: > >>> Convert the binding to DT schema format. Besides, this also add other > >>> optional properties not contained in txt file. > >> > >> Why ones do you add? > > > > I add clock, power-domains and phy-3p0-supply to this doc. Because > > the txt file should contain these properties but it not. I think the > > txt doesn't get update in time. > > Can you mention them in commit msg? Sure. Thanks, Xu Yang > > > > > >>> + reg: > >>> + minItems: 1 > >>> + maxItems: 2 > >> > >> You should list the items. > >> > >>> + > >>> + interrupts: > >>> + minItems: 1 > >>> + maxItems: 2 > >> > >> You should list the items. > > > > After my check, the maxItems value of reg and interrupts should be 1. > > Will change it. > > OK > > > Best regards, > Krzysztof
On 08/06/2023 05:36, Xu Yang wrote: > The imx8ulp and imx8qm are compatible with imx8dxl. This will add such > compatible. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v2: > - no change > --- > Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > index 1b6b19fdf491..1395a982c387 100644 > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > @@ -32,7 +32,10 @@ properties: > - const: fsl,imx7ulp-usbphy > - const: fsl,imx6ul-usbphy > - items: > - - const: fsl,imx8dxl-usbphy > + - enum: > + - fsl,imx8ulp-usbphy > + - fsl,imx8dxl-usbphy > + - fsl,imx8qm-usbphy Keep the items sorted. Your previous patch also had wrongly ordered imx6ul in enum. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Wednesday, June 14, 2023 3:18 AM > To: Xu Yang <xu.yang_2@nxp.com>; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org > Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux- > imx@nxp.com>; linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > usb@vger.kernel.org; Jun Li <jun.li@nxp.com> > Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible > > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the > message using the 'Report this email' button > > > On 08/06/2023 05:36, Xu Yang wrote: > > The imx8ulp and imx8qm are compatible with imx8dxl. This will add such > > compatible. > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > --- > > Changes in v2: > > - no change > > --- > > Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > index 1b6b19fdf491..1395a982c387 100644 > > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > @@ -32,7 +32,10 @@ properties: > > - const: fsl,imx7ulp-usbphy > > - const: fsl,imx6ul-usbphy > > - items: > > - - const: fsl,imx8dxl-usbphy > > + - enum: > > + - fsl,imx8ulp-usbphy > > + - fsl,imx8dxl-usbphy > > + - fsl,imx8qm-usbphy > > Keep the items sorted. Your previous patch also had wrongly ordered > imx6ul in enum. V4 already fix this issue as below: @@ -29,7 +29,10 @@ properties: - const: fsl,imx6ul-usbphy - const: fsl,imx23-usbphy - items: - - const: fsl,imx8dxl-usbphy + - enum: + - fsl,imx8dxl-usbphy + - fsl,imx8qm-usbphy + - fsl,imx8ulp-usbphy - const: fsl,imx7ulp-usbphy Thanks, Xu Yang > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml new file mode 100644 index 000000000000..1b6b19fdf491 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml @@ -0,0 +1,128 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale MXS USB Phy Device + +maintainers: + - Xu Yang <xu.yang_2@nxp.com> + +properties: + compatible: + oneOf: + - enum: + - fsl,imx23-usbphy + - fsl,vf610-usbphy + - fsl,imx7ulp-usbphy + - items: + - enum: + - fsl,imx28-usbphy + - fsl,imx6ul-usbphy + - fsl,imx6sl-usbphy + - fsl,imx6sx-usbphy + - fsl,imx6q-usbphy + - const: fsl,imx23-usbphy + - items: + - const: fsl,imx6sll-usbphy + - const: fsl,imx6ul-usbphy + - const: fsl,imx23-usbphy + - items: + - const: fsl,imx7ulp-usbphy + - const: fsl,imx6ul-usbphy + - items: + - const: fsl,imx8dxl-usbphy + - const: fsl,imx7ulp-usbphy + + reg: + minItems: 1 + maxItems: 2 + + interrupts: + minItems: 1 + maxItems: 2 + + clocks: + maxItems: 1 + + '#phy-cells': + const: 0 + + power-domains: + maxItems: 1 + + fsl,anatop: + description: + phandle for anatop register, it is only for imx6 SoC series. + $ref: /schemas/types.yaml#/definitions/phandle + + phy-3p0-supply: + description: + One of USB PHY's power supply. Can be used to keep a good signal + quality. + + fsl,tx-cal-45-dn-ohms: + description: + Resistance (in ohms) of switchable high-speed trimming resistor + connected in parallel with the 45 ohm resistor that terminates + the DN output signal. + minimum: 35 + maximum: 54 + default: 45 + + fsl,tx-cal-45-dp-ohms: + description: + Resistance (in ohms) of switchable high-speed trimming resistor + connected in parallel with the 45 ohm resistor that terminates + the DP output signal. + minimum: 35 + maximum: 54 + default: 45 + + fsl,tx-d-cal: + description: + Current trimming value (as a percentage) of the 17.78 mA TX + reference current. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 79 + maximum: 119 + default: 100 + +required: + - compatible + - reg + - clocks + +allOf: + - if: + properties: + compatible: + oneOf: + - enum: + - fsl,imx6sl-usbphy + - fsl,imx6sx-usbphy + - fsl,imx6sll-usbphy + - fsl,imx6q-usbphy + - fsl,vf610-usbphy + - items: + - const: fsl,imx6ul-usbphy + - const: fsl,imx23-usbphy + then: + required: + - fsl,anatop + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + usbphy1: usb-phy@20c9000 { + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy"; + reg = <0x020c9000 0x1000>; + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; + fsl,anatop = <&anatop>; + }; + +... diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt deleted file mode 100644 index 70c813b0755f..000000000000 --- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt +++ /dev/null @@ -1,33 +0,0 @@ -* Freescale MXS USB Phy Device - -Required properties: -- compatible: should contain: - * "fsl,imx23-usbphy" for imx23 and imx28 - * "fsl,imx6q-usbphy" for imx6dq and imx6dl - * "fsl,imx6sl-usbphy" for imx6sl - * "fsl,vf610-usbphy" for Vybrid vf610 - * "fsl,imx6sx-usbphy" for imx6sx - * "fsl,imx7ulp-usbphy" for imx7ulp - * "fsl,imx8dxl-usbphy" for imx8dxl - "fsl,imx23-usbphy" is still a fallback for other strings -- reg: Should contain registers location and length -- interrupts: Should contain phy interrupt -- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series - -Optional properties: -- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable - high-speed trimming resistor connected in parallel with the 45 ohm resistor - that terminates the DN output signal. Default: 45 -- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable - high-speed trimming resistor connected in parallel with the 45 ohm resistor - that terminates the DP output signal. Default: 45 -- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of - the 17.78mA TX reference current. Default: 100 - -Example: -usbphy1: usb-phy@20c9000 { - compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy"; - reg = <0x020c9000 0x1000>; - interrupts = <0 44 0x04>; - fsl,anatop = <&anatop>; -};
Convert the binding to DT schema format. Besides, this also add other optional properties not contained in txt file. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Changes in v2: - change filename to fsl,mxs-usbphy.yaml - add other optional properties - narrow fsl,anatop to imx6 - use additionalProperties --- .../bindings/phy/fsl,mxs-usbphy.yaml | 128 ++++++++++++++++++ .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 ----- 2 files changed, 128 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt