mbox series

[v2,0/4] Minor improvements for Intel pinctrl

Message ID 20230609082539.24311-1-raag.jadav@intel.com
Headers show
Series Minor improvements for Intel pinctrl | expand

Message

Raag Jadav June 9, 2023, 8:25 a.m. UTC 
This series implements minor improvements for Intel pinctrl driver.

The optimizations are as tested with gcc 7.5.0 with default -O2.

Raag Jadav (4):
  pinctrl: intel: refine set_mux hook
  pinctrl: intel: refine irq_set_type hook
  pinctrl: intel: simplify exit path of set_mux hook
  pinctrl: intel: simplify exit path of gpio_request_enable hook

 drivers/pinctrl/intel/pinctrl-intel.c | 57 ++++++++++++++-------------
 1 file changed, 29 insertions(+), 28 deletions(-)

Comments

Mika Westerberg June 9, 2023, 9:29 a.m. UTC | #1 
On Fri, Jun 09, 2023 at 09:10:42AM +0000, Jadav, Raag wrote:
> > On Fri, Jun 09, 2023 at 01:55:38PM +0530, Raag Jadav wrote:
> > > Simplify exit path of ->set_mux() hook and save a few bytes.
> > >
> > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-22 (-22)
> > > Function                                     old     new   delta
> > > intel_pinmux_set_mux                         242     220     -22
> > > Total: Before=10453, After=10431, chg -0.21%
> > >
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > >  drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++----
> > >  1 file changed, 5 insertions(+), 4 deletions(-)
> > 
> > This adds one more line so it is not simplifying ;-)
> 
> Would "optimize" sound any better?

No, I think this patch is not useful at all.