mbox series

[v5,0/3] pinctrl: tegra: Add Tegra234 pinmux driver

Message ID 20230605154230.2910847-1-thierry.reding@gmail.com
Headers show
Series pinctrl: tegra: Add Tegra234 pinmux driver | expand

Message

Thierry Reding June 5, 2023, 3:42 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

Hi,

this is an updated version of v4 of the series, which can be found here:

	http://patchwork.ozlabs.org/project/linux-tegra/list/?series=357888

This adds the missing DT bindings example for the AON pinmux controller
and addresses some review comments from Andy that I had previously
missed.

Changes in v5:
- add missing DT bindings example for AON controller
- use generic device_get_match_data() instead of OF-specific variant
- drop comma for of_device_id table sentinel entry
- drop unneeded .owner initialization
- drop redundant license text
- add missing includes

Once accepted, patches 1 and 2 can go through the pinctrl tree and I can
pick up patch 3 into the Tegra tree. Alternatively I can also pick up
patch 1 into the Tegra tree to help with validation. We're not quite at
a point yet where the Tegra DTs fully validate, so it doesn't matter
much which way these get applied.

Thanks,
Thierry

Prathamesh Shete (3):
  dt-bindings: pinctrl: Document Tegra234 pin controllers
  pinctrl: tegra: Add Tegra234 pinmux driver
  arm64: tegra: Add Tegra234 pin controllers

 .../pinctrl/nvidia,tegra234-pinmux-aon.yaml   |   78 +
 .../nvidia,tegra234-pinmux-common.yaml        |   66 +
 .../pinctrl/nvidia,tegra234-pinmux.yaml       |  139 ++
 arch/arm64/boot/dts/nvidia/tegra234.dtsi      |   12 +
 drivers/pinctrl/tegra/Kconfig                 |    4 +
 drivers/pinctrl/tegra/Makefile                |    1 +
 drivers/pinctrl/tegra/pinctrl-tegra234.c      | 1961 +++++++++++++++++
 drivers/soc/tegra/Kconfig                     |    1 +
 8 files changed, 2262 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-common.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
 create mode 100644 drivers/pinctrl/tegra/pinctrl-tegra234.c

Comments

Krzysztof Kozlowski June 6, 2023, 8:47 a.m. UTC | #1
On 05/06/2023 17:42, Thierry Reding wrote:
> From: Prathamesh Shete <pshete@nvidia.com>
> 
> Tegra234 contains two pin controllers. Document their compatible strings
> and describe the list of pins and functions that they provide.
> 
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Changes in v5:
> - add missing example for AON controller
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Thierry Reding June 6, 2023, 1:07 p.m. UTC | #2
On Mon, Jun 05, 2023 at 05:42:27PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Hi,
> 
> this is an updated version of v4 of the series, which can be found here:
> 
> 	http://patchwork.ozlabs.org/project/linux-tegra/list/?series=357888
> 
> This adds the missing DT bindings example for the AON pinmux controller
> and addresses some review comments from Andy that I had previously
> missed.
> 
> Changes in v5:
> - add missing DT bindings example for AON controller
> - use generic device_get_match_data() instead of OF-specific variant
> - drop comma for of_device_id table sentinel entry
> - drop unneeded .owner initialization
> - drop redundant license text
> - add missing includes
> 
> Once accepted, patches 1 and 2 can go through the pinctrl tree and I can
> pick up patch 3 into the Tegra tree. Alternatively I can also pick up
> patch 1 into the Tegra tree to help with validation. We're not quite at
> a point yet where the Tegra DTs fully validate, so it doesn't matter
> much which way these get applied.

Linus,

I've applied patches 1 and 3 to the Tegra tree. Let me know if you'd
prefer to pick up patch 1 along with patch 2 and I can drop it.

Thanks,
Thierry

> 
> Thanks,
> Thierry
> 
> Prathamesh Shete (3):
>   dt-bindings: pinctrl: Document Tegra234 pin controllers
>   pinctrl: tegra: Add Tegra234 pinmux driver
>   arm64: tegra: Add Tegra234 pin controllers
> 
>  .../pinctrl/nvidia,tegra234-pinmux-aon.yaml   |   78 +
>  .../nvidia,tegra234-pinmux-common.yaml        |   66 +
>  .../pinctrl/nvidia,tegra234-pinmux.yaml       |  139 ++
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi      |   12 +
>  drivers/pinctrl/tegra/Kconfig                 |    4 +
>  drivers/pinctrl/tegra/Makefile                |    1 +
>  drivers/pinctrl/tegra/pinctrl-tegra234.c      | 1961 +++++++++++++++++
>  drivers/soc/tegra/Kconfig                     |    1 +
>  8 files changed, 2262 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux-common.yaml
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
>  create mode 100644 drivers/pinctrl/tegra/pinctrl-tegra234.c
> 
> -- 
> 2.40.1
>
Linus Walleij June 9, 2023, 7:16 a.m. UTC | #3
On Mon, Jun 5, 2023 at 5:42 PM Thierry Reding <thierry.reding@gmail.com> wrote:

> this is an updated version of v4 of the series, which can be found here:

Patches 1 & 2 applied to the pinctrl tree, great work on this series!

>   arm64: tegra: Add Tegra234 pin controllers

Please funnel this final patch through the SoC tree.

Yours,
Linus Walleij