| Message ID | 20230523122802.1.Id68e30343bb1e11470582a9078b086176cfec46b@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together | expand |
On 23/05/2023 21:27, Douglas Anderson wrote: > As talked about in the patch ("drm/panel: Add a way for other devices > to follow panel state"), touchscreens that are connected to panels are > generally expected to be power sequenced together with the panel > they're attached to. Today, nothing provides information allowing you > to find out that a touchscreen is connected to a panel. Let's add a > phandle for this. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 6 ++++++ > Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 6 ++++++ > Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++ > 3 files changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > index 05e6f2df604c..d55b03bd3ec4 100644 > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > @@ -24,6 +24,12 @@ properties: > interrupts: > maxItems: 1 > > + panel: > + description: If this is a touchscreen, the panel it's connected to. This Hm, can there be different setup? Touchscreen without panel? What would it be then? Why only these touchscreens? This looks generic, so maybe in touchscreen.yaml? Best regards, Krzysztof
Hi, On Tue, May 30, 2023 at 8:34 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 23/05/2023 21:27, Douglas Anderson wrote: > > As talked about in the patch ("drm/panel: Add a way for other devices > > to follow panel state"), touchscreens that are connected to panels are > > generally expected to be power sequenced together with the panel > > they're attached to. Today, nothing provides information allowing you > > to find out that a touchscreen is connected to a panel. Let's add a > > phandle for this. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 6 ++++++ > > Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 6 ++++++ > > Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++ > > 3 files changed, 18 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > index 05e6f2df604c..d55b03bd3ec4 100644 > > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > @@ -24,6 +24,12 @@ properties: > > interrupts: > > maxItems: 1 > > > > + panel: > > + description: If this is a touchscreen, the panel it's connected to. This > > Hm, can there be different setup? Touchscreen without panel? What would > it be then? For a touchscreen that's a discrete device (not sharing logic / power rails with the panel) you'd just leave off the panel node like we've always done. Assuming folks like this series in general, I'll try to improve the wording for v2. > Why only these touchscreens? This looks generic, so maybe in > touchscreen.yaml? Ah, that makes sense. I guess we need to add an include of that file from the elan and goodix bindings. The hid-over-i2c.yaml already has it, though. I'm not 100% sure the existing "hid-over-i2c" driver in Linux actually calls the function to parse all those properties, but I guess that's a Linux problem and not a DT bindings problem. ;-) -Doug
diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml index 05e6f2df604c..d55b03bd3ec4 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml @@ -24,6 +24,12 @@ properties: interrupts: maxItems: 1 + panel: + description: If this is a touchscreen, the panel it's connected to. This + indicates that the panel and touchscreen are expected to be power + sequenced together. + $ref: /schemas/types.yaml#/definitions/phandle + reset-gpios: description: Reset GPIO; not all touchscreens using eKTH6915 hook this up. diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml index ce18d7dadae2..a5cd8dafd450 100644 --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml @@ -30,6 +30,12 @@ properties: interrupts: maxItems: 1 + panel: + description: If this is a touchscreen, the panel it's connected to. This + indicates that the panel and touchscreen are expected to be power + sequenced together. + $ref: /schemas/types.yaml#/definitions/phandle + reset-gpios: true diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml index 7156b08f7645..c7ea6c148838 100644 --- a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml @@ -44,6 +44,12 @@ properties: description: HID descriptor address $ref: /schemas/types.yaml#/definitions/uint32 + panel: + description: If this is a touchscreen, the panel it's connected to. This + indicates that the panel and touchscreen are expected to be power + sequenced together. + $ref: /schemas/types.yaml#/definitions/phandle + post-power-on-delay-ms: description: Time required by the device after enabling its regulators or powering it on, before it is ready for communication.
As talked about in the patch ("drm/panel: Add a way for other devices to follow panel state"), touchscreens that are connected to panels are generally expected to be power sequenced together with the panel they're attached to. Today, nothing provides information allowing you to find out that a touchscreen is connected to a panel. Let's add a phandle for this. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 6 ++++++ Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 6 ++++++ Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++ 3 files changed, 18 insertions(+)