| Message ID | 2035c65977818626011f512d17cd018b6d877925.1684595848.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | New |
| Headers | show |
| Series | Bluetooth: hci_ll: Use the devm_clk_get_optional() helper | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=749494 ---Test result--- Test Summary: CheckPatch PASS 0.72 seconds GitLint PASS 0.36 seconds SubjectPrefix PASS 0.14 seconds BuildKernel PASS 32.27 seconds CheckAllWarning PASS 35.06 seconds CheckSparse PASS 39.96 seconds CheckSmatch PASS 108.89 seconds BuildKernel32 PASS 31.10 seconds TestRunnerSetup PASS 446.95 seconds TestRunner_l2cap-tester PASS 17.26 seconds TestRunner_iso-tester PASS 21.31 seconds TestRunner_bnep-tester PASS 5.71 seconds TestRunner_mgmt-tester PASS 116.57 seconds TestRunner_rfcomm-tester PASS 9.09 seconds TestRunner_sco-tester PASS 8.35 seconds TestRunner_ioctl-tester PASS 9.72 seconds TestRunner_mesh-tester PASS 7.16 seconds TestRunner_smp-tester PASS 8.31 seconds TestRunner_userchan-tester PASS 5.99 seconds IncrementalBuild PASS 29.29 seconds --- Regards, Linux Bluetooth
diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c index 4a0b5c3160c2..de463d8bf265 100644 --- a/drivers/bluetooth/hci_ll.c +++ b/drivers/bluetooth/hci_ll.c @@ -129,8 +129,7 @@ static int ll_open(struct hci_uart *hu) if (hu->serdev) { struct ll_device *lldev = serdev_device_get_drvdata(hu->serdev); - if (!IS_ERR(lldev->ext_clk)) - clk_prepare_enable(lldev->ext_clk); + clk_prepare_enable(lldev->ext_clk); } return 0; @@ -703,8 +702,8 @@ static int hci_ti_probe(struct serdev_device *serdev) if (IS_ERR(lldev->enable_gpio)) return PTR_ERR(lldev->enable_gpio); - lldev->ext_clk = devm_clk_get(&serdev->dev, "ext_clock"); - if (IS_ERR(lldev->ext_clk) && PTR_ERR(lldev->ext_clk) != -ENOENT) + lldev->ext_clk = devm_clk_get_optional(&serdev->dev, "ext_clock"); + if (IS_ERR(lldev->ext_clk)) return PTR_ERR(lldev->ext_clk); of_property_read_u32(serdev->dev.of_node, "max-speed", &max_speed);
Use devm_clk_get_optional() instead of hand writing it. This is slightly less verbose and improves the semantic. This also simplifies ll_open() because clk_prepare_enable() already handles NULL clk. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/bluetooth/hci_ll.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)