diff mbox series

[v2,1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties

Message ID 20230417080818.28398-1-krzysztof.kozlowski@linaro.org
State Superseded
Headers show
Series [v2,1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties | expand

Commit Message

Krzysztof Kozlowski April 17, 2023, 8:08 a.m. UTC
Drop incorrect and unused serial properties - address/size-cells and
reg-names:

  sa8155p-adp.dtb: geniqup@ac0000: serial@a84000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'reg-names' were unexpected)

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v1:
1. Add Rb tag.
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 ---
 1 file changed, 3 deletions(-)

Comments

Konrad Dybcio April 17, 2023, 8:19 a.m. UTC | #1
On 17.04.2023 10:09, Krzysztof Kozlowski wrote:
> Since commit 6c84bbd103d8 ("dt-bindings: arm-smmu: Add generic
> qcom,smmu-500 bindings") the SMMU is supposed to use qcom,smmu-500
> compatible fallback.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
> Changes since v1:
> 1. Correct compatible and commit msg (Konrad).
> ---
>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 3846f5e0f656..25085621ef49 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3983,7 +3983,7 @@ spmi_bus: spmi@c440000 {
>  		};
>  
>  		apps_smmu: iommu@15000000 {
> -			compatible = "qcom,sm8150-smmu-500", "arm,mmu-500";
> +			compatible = "qcom,sm8150-smmu-500", "qcom,smmu-500", "arm,mmu-500";
>  			reg = <0 0x15000000 0 0x100000>;
>  			#iommu-cells = <2>;
>  			#global-interrupts = <1>;
Bjorn Andersson May 15, 2023, 3:33 a.m. UTC | #2
On Mon, 17 Apr 2023 10:08:15 +0200, Krzysztof Kozlowski wrote:
> Drop incorrect and unused serial properties - address/size-cells and
> reg-names:
> 
>   sa8155p-adp.dtb: geniqup@ac0000: serial@a84000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'reg-names' were unexpected)
> 
> 

Applied, thanks!

[1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties
      commit: e10094bf590696a7f845790485cc3f753b2fd94a
[2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback
      commit: 83254172fa7f4d4a400f2ff441f111e424dd5ee0
[3/4] arm64: dts: qcom: sm8150: drop snps,dw-pcie fallback compatible
      commit: 7df522338d63c42946eb82f8af7dba8c363bd725
[4/4] arm64: dts: qcom: sc8280xp: correct GIC child node name
      commit: 9230758996c3ff0b5cf8e8506731c956bfb351bf

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 27dcda0d4288..3846f5e0f656 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1362,14 +1362,11 @@  spi9: spi@a84000 {
 			uart9: serial@a84000 {
 				compatible = "qcom,geni-uart";
 				reg = <0x0 0x00a84000 0x0 0x4000>;
-				reg-names = "se";
 				clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>;
 				clock-names = "se";
 				pinctrl-0 = <&qup_uart9_default>;
 				pinctrl-names = "default";
 				interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
-				#address-cells = <1>;
-				#size-cells = <0>;
 				status = "disabled";
 			};