| Message ID | 20230426-stmpe-dt-bindings-v3-0-eac1d736e488@linaro.org |
|---|---|
| Headers | show |
| Series | STMPE device tree bindings | expand |
On Sun, 07 May 2023 23:19:19 +0200, Linus Walleij wrote: > This adds a schema for the STMPE GPIO that while it is used a > lot in the kernel tree is anyway missing its bindings. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v2->v3: > - Use a compact hog node schema backed by the standard hog > schema. > ChangeLog v1->v2: > - New patch split off from the MFD patch. > --- > .../devicetree/bindings/gpio/st,stmpe-gpio.yaml | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml doc reference errors (make refcheckdocs): Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230426-stmpe-dt-bindings-v3-1-eac1d736e488@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, May 8, 2023 at 12:26 AM Rob Herring <robh@kernel.org> wrote: > On Sun, 07 May 2023 23:19:19 +0200, Linus Walleij wrote: > > This adds a schema for the STMPE GPIO that while it is used a > > lot in the kernel tree is anyway missing its bindings. > > > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > --- > > ChangeLog v2->v3: > > - Use a compact hog node schema backed by the standard hog > > schema. > > ChangeLog v1->v2: > > - New patch split off from the MFD patch. > > --- > > .../devicetree/bindings/gpio/st,stmpe-gpio.yaml | 51 ++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml Looks like these are not mine... Yours, Linus Walleij
On 07/05/2023 23:19, Linus Walleij wrote: > This adds a schema for the STMPE GPIO that while it is used a > lot in the kernel tree is anyway missing its bindings. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v2->v3: > - Use a compact hog node schema backed by the standard hog > schema. > ChangeLog v1->v2: > - New patch split off from the MFD patch. > --- > .../devicetree/bindings/gpio/st,stmpe-gpio.yaml | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) This should be a conversion of Documentation/devicetree/bindings/gpio/gpio-stmpe.txt: 1. Expressed in subject, commit msg, 2. With changes against original binding mentioned in commit msg, 3. With removal of old file. > > diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml > new file mode 100644 > index 000000000000..41aa82b8b3eb > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/st,stmpe-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectonics Port Expander (STMPE) GPIO Block > + > +description: STMicroelectronics Port Expander (STMPE) is a series of slow If there is resend/new version, put blank line after description: > + bus controllers for various expanded peripherals such as GPIO, keypad, > + touchscreen, ADC, PWM or rotator. It can contain one or several different > + peripherals connected to SPI or I2C. These bindings pertain to the > + GPIO portions of these expanders. > + > +maintainers: > + - Linus Walleij <linus.walleij@linaro.org> > + > +properties: > + compatible: > + const: st,stmpe-gpio > + > + "#gpio-cells": > + const: 2 > + > + "#interrupt-cells": > + const: 2 > + > + gpio-controller: true > + > + interrupt-controller: true > + > + st,norequest-mask: > + description: A bitmask of GPIO lines that cannot be requested because for > + for example not being connected to anything on the system Here as well. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > +patternProperties: > + "^.+-hog(-[0-9]+)?$": > + type: object > + > + required: > + - gpio-hog > + Best regards, Krzysztof
On 07/05/2023 23:19, Linus Walleij wrote: > This adds the missing GPIO bindings for the STMPE port expander > and converts the existing MFD binding to YAML. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > Changes in v3: > - Update to review feedback > - Collected some ack/review tags > - I guess Bartosz should apply 1/2 and Lee should apply 2/2. > - Link to v2: https://lore.kernel.org/r/20230426-stmpe-dt-bindings-v2-0-2f85a1fffcda@linaro.org 2/2 depends on 1/2, so it must go via one tree. Best regards, Krzysztof
On Mon, May 8, 2023 at 11:39 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 07/05/2023 23:19, Linus Walleij wrote: > > This adds the missing GPIO bindings for the STMPE port expander > > and converts the existing MFD binding to YAML. > > > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > --- > > Changes in v3: > > - Update to review feedback > > - Collected some ack/review tags > > - I guess Bartosz should apply 1/2 and Lee should apply 2/2. > > - Link to v2: https://lore.kernel.org/r/20230426-stmpe-dt-bindings-v2-0-2f85a1fffcda@linaro.org > > 2/2 depends on 1/2, so it must go via one tree. Ah you're right. I hope Lee can take it all then. Or the DT tree. Yours, Linus Walleij
This adds the missing GPIO bindings for the STMPE port expander and converts the existing MFD binding to YAML. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- Changes in v3: - Update to review feedback - Collected some ack/review tags - I guess Bartosz should apply 1/2 and Lee should apply 2/2. - Link to v2: https://lore.kernel.org/r/20230426-stmpe-dt-bindings-v2-0-2f85a1fffcda@linaro.org Changes in v2: - Split off a separate GPIO binding - Updated the MFD binding according to feedback --- Linus Walleij (2): dt-bindings: gpio: Add STMPE YAML DT schema dt-bindings: MFD: Convert STMPE to YAML schema .../devicetree/bindings/gpio/st,stmpe-gpio.yaml | 51 ++++ .../devicetree/bindings/input/stmpe-keypad.txt | 41 --- .../bindings/input/touchscreen/stmpe.txt | 108 -------- .../devicetree/bindings/mfd/st,stmpe.yaml | 297 +++++++++++++++++++++ Documentation/devicetree/bindings/mfd/stmpe.txt | 42 --- 5 files changed, 348 insertions(+), 191 deletions(-) --- base-commit: c712a112ed4e91afab1cc7c978af228c77a4fb13 change-id: 20230426-stmpe-dt-bindings-c3479dd71a28 Best regards,