| Message ID | cover.1683183860.git.quic_varada@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable IPQ9754 USB | expand |
On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > Updated USB QMP PHY Init sequence based on HPG for IPQ9574. > Reused clock and reset list from existing targets. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Changes in v6: > - Fix pcs_usb offset > - Use correct clock names array > Changes in v5: > - Fix additional review comments > - Use V3 register offsets > Changes in v4: > - Use qmp_usb_offsets for register space access > Changes in v3: > - Fix hex captitalization > Changes in v2: > - Removed unused phy register offsets > - Moved the clock entries to the correct place > - Maintain sorted order > --- > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 115 ++++++++++++++++++++++++++++++++ > 1 file changed, 115 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> -- With best wishes Dmitry
On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > Add LDO regulator node As this LDO is provided by the PMIC, it would be nice to know why it is modelled as an always-on regulator instead of the proper PMIC regulator. Up to now we were doing this only for the outstanding power rails like CX/MX or EBI. > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Changes in v10: > - Add LDO regulator node > --- > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > index bdc1434..1f5d14f 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > @@ -60,6 +60,13 @@ > regulator-min-microvolt = <725000>; > regulator-max-microvolt = <1075000>; > }; > + > + mp5496_l2: l2 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > }; > > -- > 2.7.4 >
On 5.05.2023 11:29, Dmitry Baryshkov wrote: > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: >> >> Add LDO regulator node > > As this LDO is provided by the PMIC, it would be nice to know why it > is modelled as an always-on regulator instead of the proper PMIC > regulator. Up to now we were doing this only for the outstanding power > rails like CX/MX or EBI. (which we then stopped registering as regulators and started to manage through rpm(h)pd drivers and the genpd framework) Konrad > >> >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> --- >> Changes in v10: >> - Add LDO regulator node >> --- >> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> index bdc1434..1f5d14f 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> @@ -60,6 +60,13 @@ >> regulator-min-microvolt = <725000>; >> regulator-max-microvolt = <1075000>; >> }; >> + >> + mp5496_l2: l2 { >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> }; >> }; >> >> -- >> 2.7.4 >> > >
On Fri, 5 May 2023 at 22:26, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 5.05.2023 11:29, Dmitry Baryshkov wrote: > > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > > <quic_varada@quicinc.com> wrote: > >> > >> Add LDO regulator node > > > > As this LDO is provided by the PMIC, it would be nice to know why it > > is modelled as an always-on regulator instead of the proper PMIC > > regulator. Up to now we were doing this only for the outstanding power > > rails like CX/MX or EBI. > (which we then stopped registering as regulators and started > to manage through rpm(h)pd drivers and the genpd framework) I mean having regulator-fixed s4a on sm8250 in addition to the CX genpd, because some of the parts really expect to have a regulator. But anyway, we are getting away from the subj. Let's wait for the answer from Varadarajan. > > Konrad > > > >> > >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > >> --- > >> Changes in v10: > >> - Add LDO regulator node > >> --- > >> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> index bdc1434..1f5d14f 100644 > >> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> @@ -60,6 +60,13 @@ > >> regulator-min-microvolt = <725000>; > >> regulator-max-microvolt = <1075000>; > >> }; > >> + > >> + mp5496_l2: l2 { > >> + regulator-min-microvolt = <1800000>; > >> + regulator-max-microvolt = <1800000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> }; > >> };
On Fri, May 05, 2023 at 12:29:54PM +0300, Dmitry Baryshkov wrote: > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: > > > > Add LDO regulator node > > As this LDO is provided by the PMIC, it would be nice to know why it > is modelled as an always-on regulator instead of the proper PMIC > regulator. Up to now we were doing this only for the outstanding power > rails like CX/MX or EBI. These are always ON because USB phy doesn't support power collapse, and there is a chance that other IP blocks might be sharing the rail. Thanks Varada > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Changes in v10: > > - Add LDO regulator node > > --- > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > index bdc1434..1f5d14f 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > @@ -60,6 +60,13 @@ > > regulator-min-microvolt = <725000>; > > regulator-max-microvolt = <1075000>; > > }; > > + > > + mp5496_l2: l2 { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > }; > > }; > > > > -- > > 2.7.4 > > > > > -- > With best wishes > Dmitry
On Sat, 6 May 2023 at 14:09, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > On Fri, May 05, 2023 at 12:29:54PM +0300, Dmitry Baryshkov wrote: > > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > > <quic_varada@quicinc.com> wrote: > > > > > > Add LDO regulator node > > > > As this LDO is provided by the PMIC, it would be nice to know why it > > is modelled as an always-on regulator instead of the proper PMIC > > regulator. Up to now we were doing this only for the outstanding power > > rails like CX/MX or EBI. > > These are always ON because USB phy doesn't support power > collapse, and there is a chance that other IP blocks might be > sharing the rail. You are describing the software side here. From the hardware point of view, it is an I2C regulator, which is probably also exported as an SMD_RPM regulator. Unless you have a good reason not to do so, there should be a node under rpm-requests, which describes mp5496 regulators exported via RPM. then USB should refer to those regulators. > > Thanks > Varada > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > --- > > > Changes in v10: > > > - Add LDO regulator node > > > --- > > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > index bdc1434..1f5d14f 100644 > > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > @@ -60,6 +60,13 @@ > > > regulator-min-microvolt = <725000>; > > > regulator-max-microvolt = <1075000>; > > > }; > > > + > > > + mp5496_l2: l2 { > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > }; > > > }; > > > > > > -- > > > 2.7.4 > > > > > > > > > -- > > With best wishes > > Dmitry
This patch series adds the relevant phy and controller configurations for enabling USB on IPQ9754 Depends on: https://lore.kernel.org/all/20230217142030.16012-1-quic_devipriy@quicinc.com/ https://lore.kernel.org/lkml/20230407155727.20615-1-quic_devipriy@quicinc.com/T/ [v10]: - Fix regulator definitions - Address couple of other comments [v9]: - Update bindings to make power-domains as optional since IPQ9574 doesn't have GDSCs [v8]: - Update bindings for the clock name change [v7]: - com_aux -> cfg_ahb in patch 7 [v6]: - Incorporated review comments - Resolve make dtbs_check messages - Fixed pcs_usb offset - Board dts file name changed [v5]: - Incorporated review comments - 'make dtbs_check' giving the following messages since ipq9574 doesn't have power domains. Hope this is ok /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: phy@7d000: 'power-domains' is a required property From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: usb@8a00000: 'power-domains' is a required property From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml - Move qmp phy DT node to newer specification [v4]: - Incorporated review comments - Address all 'make dtbs_check' errors [v3]: - Incorporated review comments regarding coding style [v2]: - Incorporated review comments regarding coding style, maintaining sorted order of entries and unused phy register offsets - Removed NOC clock entries from DT node (will be implemented later with interconnect support) - Fixed 'make dtbs_check' errors/warnings [v1]: https://lore.kernel.org/linux-arm-msm/5dac3aa4-8dc7-f9eb-5cf3-b361efdc9494@linaro.org/T/ Varadarajan Narayanan (9): dt-bindings: phy: qcom,qusb2: Document IPQ9574 compatible dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY dt-bindings: usb: dwc3: Add IPQ9574 compatible clk: qcom: gcc-ipq9574: Add USB related clocks phy: qcom-qusb2: add QUSB2 support for IPQ9574 phy: qcom: qmp: Update IPQ9574 USB Phy initialization Sequence arm64: dts: qcom: ipq9574: Add USB related nodes arm64: dts: qcom: ipq9574: Add LDO regulator node arm64: dts: qcom: ipq9574: Enable USB .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 3 +- .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 41 ++++++-- .../devicetree/bindings/usb/qcom,dwc3.yaml | 3 +- arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 30 ++++++ arch/arm64/boot/dts/qcom/ipq9574.dtsi | 104 +++++++++++++++++++ drivers/clk/qcom/gcc-ipq9574.c | 37 +++++++ drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 115 +++++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 + include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 + 9 files changed, 330 insertions(+), 8 deletions(-)