| Message ID | 20230501105832.1185477-2-bhupesh.sharma@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/3] arm64: dts: qcom: qrb4210-rb2: Add SD pinctrl states | expand |
On 1.05.2023 12:58, Bhupesh Sharma wrote: > Add the default and sleep pinctrl states for SDHC1 & 2 controllers > on QRB4210 RB2 board. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index dc80f0bca767..5a5294cc6e45 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -190,6 +190,10 @@ vreg_l24a_2p96: l24 { > }; > > &sdhc_1 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc1_state_on>; > + pinctrl-1 = <&sdc1_state_off>; property-n property-names Other than that: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > + > vmmc-supply = <&vreg_l24a_2p96>; > vqmmc-supply = <&vreg_l11a_1p8>; > no-sdio; > @@ -200,6 +204,10 @@ &sdhc_1 { > > &sdhc_2 { > cd-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>; /* card detect gpio */ > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_state_on &sdc2_card_det_n>; > + pinctrl-1 = <&sdc2_state_off &sdc2_card_det_n>; > + > vmmc-supply = <&vreg_l22a_2p96>; > vqmmc-supply = <&vreg_l5a_2p96>; > no-sdio; > @@ -216,6 +224,13 @@ &tlmm { > <49 1>, <52 1>, <54 1>, > <56 3>, <61 2>, <64 1>, > <68 1>, <72 8>, <96 1>; > + > + sdc2_card_det_n: sd-card-det-n-state { > + pins = "gpio88"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > }; > > &uart4 {
On Tue, 2 May 2023 at 17:27, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 1.05.2023 12:58, Bhupesh Sharma wrote: > > Add the default and sleep pinctrl states for SDHC1 & 2 controllers > > on QRB4210 RB2 board. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > index dc80f0bca767..5a5294cc6e45 100644 > > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > @@ -190,6 +190,10 @@ vreg_l24a_2p96: l24 { > > }; > > > > &sdhc_1 { > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&sdc1_state_on>; > > + pinctrl-1 = <&sdc1_state_off>; > property-n > property-names > > Other than that: > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Sure, let me fix this in v3. Thanks, Bhupesh
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts index dc80f0bca767..5a5294cc6e45 100644 --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts @@ -190,6 +190,10 @@ vreg_l24a_2p96: l24 { }; &sdhc_1 { + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc1_state_on>; + pinctrl-1 = <&sdc1_state_off>; + vmmc-supply = <&vreg_l24a_2p96>; vqmmc-supply = <&vreg_l11a_1p8>; no-sdio; @@ -200,6 +204,10 @@ &sdhc_1 { &sdhc_2 { cd-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>; /* card detect gpio */ + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc2_state_on &sdc2_card_det_n>; + pinctrl-1 = <&sdc2_state_off &sdc2_card_det_n>; + vmmc-supply = <&vreg_l22a_2p96>; vqmmc-supply = <&vreg_l5a_2p96>; no-sdio; @@ -216,6 +224,13 @@ &tlmm { <49 1>, <52 1>, <54 1>, <56 3>, <61 2>, <64 1>, <68 1>, <72 8>, <96 1>; + + sdc2_card_det_n: sd-card-det-n-state { + pins = "gpio88"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; }; &uart4 {
Add the default and sleep pinctrl states for SDHC1 & 2 controllers on QRB4210 RB2 board. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)