| Message ID | 20230504194453.1150368-14-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Commit | 07336df6696bac3a7049f31e972acaaaf05e3101 |
| Headers | show |
| Series | remoteproc: Convert to platform remove callback returning void | expand |
On 04/05/2023 20:44, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > drivers/remoteproc/qcom_wcnss.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c > index 0fc317265064..1ed0647bc962 100644 > --- a/drivers/remoteproc/qcom_wcnss.c > +++ b/drivers/remoteproc/qcom_wcnss.c > @@ -666,7 +666,7 @@ static int wcnss_probe(struct platform_device *pdev) > return ret; > } > > -static int wcnss_remove(struct platform_device *pdev) > +static void wcnss_remove(struct platform_device *pdev) > { > struct qcom_wcnss *wcnss = platform_get_drvdata(pdev); > > @@ -678,8 +678,6 @@ static int wcnss_remove(struct platform_device *pdev) > qcom_remove_smd_subdev(wcnss->rproc, &wcnss->smd_subdev); > wcnss_release_pds(wcnss); > rproc_free(wcnss->rproc); > - > - return 0; > } > > static const struct of_device_id wcnss_of_match[] = { > @@ -693,7 +691,7 @@ MODULE_DEVICE_TABLE(of, wcnss_of_match); > > static struct platform_driver wcnss_driver = { > .probe = wcnss_probe, > - .remove = wcnss_remove, > + .remove_new = wcnss_remove, > .driver = { > .name = "qcom-wcnss-pil", > .of_match_table = wcnss_of_match,
diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c index 0fc317265064..1ed0647bc962 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -666,7 +666,7 @@ static int wcnss_probe(struct platform_device *pdev) return ret; } -static int wcnss_remove(struct platform_device *pdev) +static void wcnss_remove(struct platform_device *pdev) { struct qcom_wcnss *wcnss = platform_get_drvdata(pdev); @@ -678,8 +678,6 @@ static int wcnss_remove(struct platform_device *pdev) qcom_remove_smd_subdev(wcnss->rproc, &wcnss->smd_subdev); wcnss_release_pds(wcnss); rproc_free(wcnss->rproc); - - return 0; } static const struct of_device_id wcnss_of_match[] = { @@ -693,7 +691,7 @@ MODULE_DEVICE_TABLE(of, wcnss_of_match); static struct platform_driver wcnss_driver = { .probe = wcnss_probe, - .remove = wcnss_remove, + .remove_new = wcnss_remove, .driver = { .name = "qcom-wcnss-pil", .of_match_table = wcnss_of_match,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/remoteproc/qcom_wcnss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)