| Message ID | 20230417181342.v2.1.I483a676579cc7e3ac07e1db649091553743fecc8@changeid |
|---|---|
| State | Accepted |
| Commit | 378b0e9f247450c9c4e49f02d9d79799a0c7c349 |
| Headers | show |
| Series | [v2] dt-bindings: mfd: stm32: Remove unnecessary blank lines | expand |
On 17/04/2023 18:14, Patrick Delaunay wrote: > Remove double blank line. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > Changes in v2: > - update commit title and commit message to reflect what the change is > V1="dt-bindings: mfd: stm32: Fix STM32F4 DT include fil More than one file has the same issue. This is quite a churn to handle such patch one by one. Please fix all of them or just skip, as it is harmless. Best regards, Krzysztof
Hi, On 4/18/23 09:22, Krzysztof Kozlowski wrote: > On 17/04/2023 18:14, Patrick Delaunay wrote: >> Remove double blank line. >> >> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >> --- >> >> Changes in v2: >> - update commit title and commit message to reflect what the change is >> V1="dt-bindings: mfd: stm32: Fix STM32F4 DT include fil > More than one file has the same issue. This is quite a churn to handle > such patch one by one. Please fix all of them or just skip, as it is > harmless. To be crystal clear, it is minor difference between files in U-Boot and in Linux, just because we correct the check-patch errors when this file for STM32F4 was up streamed in U-Boot. I prefer correct this line in the Linux file and no having this difference for each device tree synchronization with U-Boot. But if you prefer, you can drop this modification and I will align U-Boot file with this error. Alexandre: it could part of patch for STM32 files clean-up ? scripts/checkpatch.pl -f include/dt-bindings/*/*stm* scripts/checkpatch.pl -f arch/arm/boot/dts/stm* > > Best regards, > Krzysztof Regards Patrick
On 18/04/2023 15:03, Patrick DELAUNAY wrote: > Hi, > > On 4/18/23 09:22, Krzysztof Kozlowski wrote: >> On 17/04/2023 18:14, Patrick Delaunay wrote: >>> Remove double blank line. >>> >>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >>> --- >>> >>> Changes in v2: >>> - update commit title and commit message to reflect what the change is >>> V1="dt-bindings: mfd: stm32: Fix STM32F4 DT include fil >> More than one file has the same issue. This is quite a churn to handle >> such patch one by one. Please fix all of them or just skip, as it is >> harmless. > > > To be crystal clear, it is minor difference between files in U-Boot > > and in Linux, just because we correct the check-patch errors > > when this file for STM32F4 was up streamed in U-Boot. > > > I prefer correct this line in the Linux file and no having > > this difference for each device tree synchronization with U-Boot. I don't know what is there in U-Boot, so my comment was not about it. I prefer all the files in Linux kernel being correct, but done once for all. Not once for stm32XX, then later for stm32XY and then stm32XZ... Best regards, Krzysztof
diff --git a/include/dt-bindings/mfd/stm32f4-rcc.h b/include/dt-bindings/mfd/stm32f4-rcc.h index 309e8c79f27b..36448a5619a1 100644 --- a/include/dt-bindings/mfd/stm32f4-rcc.h +++ b/include/dt-bindings/mfd/stm32f4-rcc.h @@ -34,7 +34,6 @@ #define STM32F4_AHB1_RESET(bit) (STM32F4_RCC_AHB1_##bit + (0x10 * 8)) #define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit) - /* AHB2 */ #define STM32F4_RCC_AHB2_DCMI 0 #define STM32F4_RCC_AHB2_CRYP 4
Remove double blank line. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- Changes in v2: - update commit title and commit message to reflect what the change is V1="dt-bindings: mfd: stm32: Fix STM32F4 DT include file" include/dt-bindings/mfd/stm32f4-rcc.h | 1 - 1 file changed, 1 deletion(-)