diff mbox series

[v2,3/5] dmaengine: plx_dma: Don't set chancnt

Message ID 20230415095517.2763-4-jszhang@kernel.org
State Superseded
Headers show
Series dma: don't set chancnt | expand

Commit Message

Jisheng Zhang April 15, 2023, 9:55 a.m. UTC 
The dma framework will calculate the dma channels chancnt, setting it
ourself is wrong.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
 drivers/dma/plx_dma.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Logan Gunthorpe April 17, 2023, 4:50 p.m. UTC | #1 
On 2023-04-15 03:55, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it
> ourself is wrong.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

Seems fine to me.

Acked-by: Logan Gunthorpe <logang@deltatee.com>

Thanks,

Logan
diff mbox series

Patch

diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
index 12725fa1655f..34b6416c3287 100644
--- a/drivers/dma/plx_dma.c
+++ b/drivers/dma/plx_dma.c
@@ -517,7 +517,6 @@  static int plx_dma_create(struct pci_dev *pdev)
 	plxdev->bar = pcim_iomap_table(pdev)[0];
 
 	dma = &plxdev->dma_dev;
-	dma->chancnt = 1;
 	INIT_LIST_HEAD(&dma->channels);
 	dma_cap_set(DMA_MEMCPY, dma->cap_mask);
 	dma->copy_align = DMAENGINE_ALIGN_1_BYTE;