| Message ID | 20230327125316.210812-4-brgl@bgdev.pl |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sa8775p: add basic PMIC support | expand |
On 27/03/2023 14:53, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add a compatible for the Power Domain Controller on SA8775p platforms. > Increase the number of PDC pin mappings. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Mar 27, 2023 at 2:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add a compatible for the Power Domain Controller on SA8775p platforms. > Increase the number of PDC pin mappings. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Marc Zyngier <maz@kernel.org> > --- > .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > index 94791e261c42..641ff32e4a6c 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > @@ -26,6 +26,7 @@ properties: > compatible: > items: > - enum: > + - qcom,sa8775p-pdc > - qcom,sc7180-pdc > - qcom,sc7280-pdc > - qcom,sc8280xp-pdc > @@ -53,7 +54,7 @@ properties: > qcom,pdc-ranges: > $ref: /schemas/types.yaml#/definitions/uint32-matrix > minItems: 1 > - maxItems: 32 # no hard limit > + maxItems: 38 # no hard limit > items: > items: > - description: starting PDC port > -- > 2.37.2 > Bjorn, Will you pick up the dt-bindings patches from this series as well or should they go through Rob's tree? Bart
On Thu, Apr 6, 2023 at 4:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Mon, Mar 27, 2023 at 2:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Add a compatible for the Power Domain Controller on SA8775p platforms. > > Increase the number of PDC pin mappings. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Marc Zyngier <maz@kernel.org> > > --- > > .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > > index 94791e261c42..641ff32e4a6c 100644 > > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > > @@ -26,6 +26,7 @@ properties: > > compatible: > > items: > > - enum: > > + - qcom,sa8775p-pdc > > - qcom,sc7180-pdc > > - qcom,sc7280-pdc > > - qcom,sc8280xp-pdc > > @@ -53,7 +54,7 @@ properties: > > qcom,pdc-ranges: > > $ref: /schemas/types.yaml#/definitions/uint32-matrix > > minItems: 1 > > - maxItems: 32 # no hard limit > > + maxItems: 38 # no hard limit > > items: > > items: > > - description: starting PDC port > > -- > > 2.37.2 > > > > Bjorn, > > Will you pick up the dt-bindings patches from this series as well or > should they go through Rob's tree? > > Bart Gentle ping as this one's still not in next. Bart
On 14/04/2023 11:33, Bartosz Golaszewski wrote: > On Thu, Apr 6, 2023 at 4:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: >> >> On Mon, Mar 27, 2023 at 2:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: >>> >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> >>> Add a compatible for the Power Domain Controller on SA8775p platforms. >>> Increase the number of PDC pin mappings. >>> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> Cc: Thomas Gleixner <tglx@linutronix.de> >>> Cc: Marc Zyngier <maz@kernel.org> >>> --- >>> .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>> index 94791e261c42..641ff32e4a6c 100644 >>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>> @@ -26,6 +26,7 @@ properties: >>> compatible: >>> items: >>> - enum: >>> + - qcom,sa8775p-pdc >>> - qcom,sc7180-pdc >>> - qcom,sc7280-pdc >>> - qcom,sc8280xp-pdc >>> @@ -53,7 +54,7 @@ properties: >>> qcom,pdc-ranges: >>> $ref: /schemas/types.yaml#/definitions/uint32-matrix >>> minItems: 1 >>> - maxItems: 32 # no hard limit >>> + maxItems: 38 # no hard limit I don't think the limit is correct. I still see warnings with this patch. We already have 57 elements, so limit should be I guess 128 or something. Best regards, Krzysztof
On Sun, Apr 16, 2023 at 5:04 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 14/04/2023 11:33, Bartosz Golaszewski wrote: > > On Thu, Apr 6, 2023 at 4:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > >> > >> On Mon, Mar 27, 2023 at 2:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > >>> > >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > >>> > >>> Add a compatible for the Power Domain Controller on SA8775p platforms. > >>> Increase the number of PDC pin mappings. > >>> > >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > >>> Cc: Thomas Gleixner <tglx@linutronix.de> > >>> Cc: Marc Zyngier <maz@kernel.org> > >>> --- > >>> .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > >>> index 94791e261c42..641ff32e4a6c 100644 > >>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > >>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml > >>> @@ -26,6 +26,7 @@ properties: > >>> compatible: > >>> items: > >>> - enum: > >>> + - qcom,sa8775p-pdc > >>> - qcom,sc7180-pdc > >>> - qcom,sc7280-pdc > >>> - qcom,sc8280xp-pdc > >>> @@ -53,7 +54,7 @@ properties: > >>> qcom,pdc-ranges: > >>> $ref: /schemas/types.yaml#/definitions/uint32-matrix > >>> minItems: 1 > >>> - maxItems: 32 # no hard limit > >>> + maxItems: 38 # no hard limit > > I don't think the limit is correct. I still see warnings with this > patch. We already have 57 elements, so limit should be I guess 128 or > something. > You mean for other platforms? This limit applies to sa8775p as the goal of the patch is to add its own PDC compatible. If other platforms have more interrupts then we need to fix it first with a separate commit IMO. I'll send out two patches for that. Brt
On 17/04/2023 09:27, Bartosz Golaszewski wrote: > On Sun, Apr 16, 2023 at 5:04 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 14/04/2023 11:33, Bartosz Golaszewski wrote: >>> On Thu, Apr 6, 2023 at 4:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: >>>> >>>> On Mon, Mar 27, 2023 at 2:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: >>>>> >>>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>>>> >>>>> Add a compatible for the Power Domain Controller on SA8775p platforms. >>>>> Increase the number of PDC pin mappings. >>>>> >>>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>>>> Cc: Thomas Gleixner <tglx@linutronix.de> >>>>> Cc: Marc Zyngier <maz@kernel.org> >>>>> --- >>>>> .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>>>> index 94791e261c42..641ff32e4a6c 100644 >>>>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>>>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>>>> @@ -26,6 +26,7 @@ properties: >>>>> compatible: >>>>> items: >>>>> - enum: >>>>> + - qcom,sa8775p-pdc >>>>> - qcom,sc7180-pdc >>>>> - qcom,sc7280-pdc >>>>> - qcom,sc8280xp-pdc >>>>> @@ -53,7 +54,7 @@ properties: >>>>> qcom,pdc-ranges: >>>>> $ref: /schemas/types.yaml#/definitions/uint32-matrix >>>>> minItems: 1 >>>>> - maxItems: 32 # no hard limit >>>>> + maxItems: 38 # no hard limit >> >> I don't think the limit is correct. I still see warnings with this >> patch. We already have 57 elements, so limit should be I guess 128 or >> something. >> > > You mean for other platforms? This limit applies to sa8775p as the I see errors on sa8775p. > goal of the patch is to add its own PDC compatible. If other platforms > have more interrupts then we need to fix it first with a separate > commit IMO. I'll send out two patches for that. Best regards, Krzysztof
On 17/04/2023 09:55, Krzysztof Kozlowski wrote: > On 17/04/2023 09:27, Bartosz Golaszewski wrote: >> On Sun, Apr 16, 2023 at 5:04 PM Krzysztof Kozlowski >> <krzysztof.kozlowski@linaro.org> wrote: >>> >>> On 14/04/2023 11:33, Bartosz Golaszewski wrote: >>>> On Thu, Apr 6, 2023 at 4:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: >>>>> >>>>> On Mon, Mar 27, 2023 at 2:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: >>>>>> >>>>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>>>>> >>>>>> Add a compatible for the Power Domain Controller on SA8775p platforms. >>>>>> Increase the number of PDC pin mappings. >>>>>> >>>>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>>>>> Cc: Thomas Gleixner <tglx@linutronix.de> >>>>>> Cc: Marc Zyngier <maz@kernel.org> >>>>>> --- >>>>>> .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 3 ++- >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>>>>> index 94791e261c42..641ff32e4a6c 100644 >>>>>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>>>>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml >>>>>> @@ -26,6 +26,7 @@ properties: >>>>>> compatible: >>>>>> items: >>>>>> - enum: >>>>>> + - qcom,sa8775p-pdc >>>>>> - qcom,sc7180-pdc >>>>>> - qcom,sc7280-pdc >>>>>> - qcom,sc8280xp-pdc >>>>>> @@ -53,7 +54,7 @@ properties: >>>>>> qcom,pdc-ranges: >>>>>> $ref: /schemas/types.yaml#/definitions/uint32-matrix >>>>>> minItems: 1 >>>>>> - maxItems: 32 # no hard limit >>>>>> + maxItems: 38 # no hard limit >>> >>> I don't think the limit is correct. I still see warnings with this >>> patch. We already have 57 elements, so limit should be I guess 128 or >>> something. >>> >> >> You mean for other platforms? This limit applies to sa8775p as the > > I see errors on sa8775p. OK, so as you pointed out it's about other platform - sa8540p-ride. Anyway you update now this line to bump the limit, so bump it to something high instead of changing it in two patches. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml index 94791e261c42..641ff32e4a6c 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml @@ -26,6 +26,7 @@ properties: compatible: items: - enum: + - qcom,sa8775p-pdc - qcom,sc7180-pdc - qcom,sc7280-pdc - qcom,sc8280xp-pdc @@ -53,7 +54,7 @@ properties: qcom,pdc-ranges: $ref: /schemas/types.yaml#/definitions/uint32-matrix minItems: 1 - maxItems: 32 # no hard limit + maxItems: 38 # no hard limit items: items: - description: starting PDC port