mbox series

[v5,0/2] Tegra I2C DMA and SMBus blockread updates

Message ID 20230413130849.2894-1-akhilrajeev@nvidia.com
Headers show
Series Tegra I2C DMA and SMBus blockread updates | expand

Message

Akhil R April 13, 2023, 1:08 p.m. UTC 
The patchset contains two independent updates to tegra-i2c driver.
* Update I2C DMA channel usage to use single DMA channel instead of
two different hardware channels.
* Fix PEC byte issue during SMBus block read caused by mismanaged
msg->len property in i2c_msg struct.

v4->v5:
 Corrected the comment style
v3->v4:
 Combine the two patches to one series to avoid merge conflicts.

Akhil R (2):
  i2c: tegra: Fix PEC support for SMBUS block read
  i2c: tegra: Share same DMA channel for RX and TX

 drivers/i2c/busses/i2c-tegra.c | 107 ++++++++++++++-------------------
 1 file changed, 46 insertions(+), 61 deletions(-)

Comments

Dmitry Osipenko April 13, 2023, 1:59 p.m. UTC | #1 
On 4/13/23 16:08, Akhil R wrote:
> @@ -279,6 +280,7 @@ struct tegra_i2c_dev {
>  	size_t msg_buf_remaining;
>  	int msg_err;
>  	u8 *msg_buf;
> +	__u16 msg_len;

It's still __u16
Akhil R April 13, 2023, 2:07 p.m. UTC | #2 
> On 4/13/23 16:08, Akhil R wrote:
> > @@ -279,6 +280,7 @@ struct tegra_i2c_dev {
> >       size_t msg_buf_remaining;
> >       int msg_err;
> >       u8 *msg_buf;
> > +     __u16 msg_len;
> 
> It's still __u16
Oh. I totally missed that comment. Will update.

Thanks,
Akhil