diff mbox series

Input: cyttsp5 - fix sensing configuration data structure

Message ID 20230411211651.3791304-1-git@hrdl.eu
State Accepted
Commit 5dc63e56a9cf8df0b59c234a505a1653f1bdf885
Headers show
Series Input: cyttsp5 - fix sensing configuration data structure | expand

Commit Message

hrdl April 11, 2023, 9:16 p.m. UTC
Prior to this patch, the sensing configuration data was not parsed
correctly, breaking detection of max_tch. The vendor driver includes
this field. This change informs the driver about the correct maximum
number of simultaneous touch inputs.

Tested on a Pine64 PineNote with a modified touch screen controller
firmware.

Signed-off-by: hrdl <git@hrdl.eu>
---
 drivers/input/touchscreen/cyttsp5.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alistair April 12, 2023, 11:06 a.m. UTC | #1
On Wed, 12 Apr 2023, at 7:16 AM, hrdl wrote:
> Prior to this patch, the sensing configuration data was not parsed
> correctly, breaking detection of max_tch. The vendor driver includes
> this field. This change informs the driver about the correct maximum
> number of simultaneous touch inputs.
> 
> Tested on a Pine64 PineNote with a modified touch screen controller
> firmware.
> 
> Signed-off-by: hrdl <git@hrdl.eu>

Reviewed-by: Alistair Francis <alistair@alistair23.me>

Alistair

> ---
> drivers/input/touchscreen/cyttsp5.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> index 16caffa35dd9..30102cb80fac 100644
> --- a/drivers/input/touchscreen/cyttsp5.c
> +++ b/drivers/input/touchscreen/cyttsp5.c
> @@ -111,6 +111,7 @@ struct cyttsp5_sensing_conf_data_dev {
> __le16 max_z;
> u8 origin_x;
> u8 origin_y;
> + u8 panel_id;
> u8 btn;
> u8 scan_mode;
> u8 max_num_of_tch_per_refresh_cycle;
> -- 
> 2.39.2
> 
>
Dmitry Torokhov April 14, 2023, 6:41 a.m. UTC | #2
On Tue, Apr 11, 2023 at 11:16:51PM +0200, hrdl wrote:
> Prior to this patch, the sensing configuration data was not parsed
> correctly, breaking detection of max_tch. The vendor driver includes
> this field. This change informs the driver about the correct maximum
> number of simultaneous touch inputs.
> 
> Tested on a Pine64 PineNote with a modified touch screen controller
> firmware.
> 
> Signed-off-by: hrdl <git@hrdl.eu>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
index 16caffa35dd9..30102cb80fac 100644
--- a/drivers/input/touchscreen/cyttsp5.c
+++ b/drivers/input/touchscreen/cyttsp5.c
@@ -111,6 +111,7 @@  struct cyttsp5_sensing_conf_data_dev {
 	__le16 max_z;
 	u8 origin_x;
 	u8 origin_y;
+	u8 panel_id;
 	u8 btn;
 	u8 scan_mode;
 	u8 max_num_of_tch_per_refresh_cycle;