| Message ID | 20230412-topic-lenovopanel-v1-0-00b25df46824@linaro.org |
|---|---|
| Headers | show |
| Series | Lenovo Tab P11 panel | expand |
On Wed, Apr 12, 2023 at 09:46:02PM +0200, Konrad Dybcio wrote: > Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3 > video mode display. Add support for these panels. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/gpu/drm/panel/panel-novatek-nt36523.c | 491 ++++++++++++++++++++++++++ > 1 file changed, 491 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c > index db4b4af13ec1..4bf9f8db26ba 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c > @@ -13,6 +13,8 @@ > #include <linux/of_graph.h> > #include <linux/regulator/consumer.h> > [..] > +static const struct panel_desc j606f_boe_desc = { > + .modes = j606f_boe_modes, > + .num_modes = ARRAY_SIZE(j606f_boe_modes), > + .dsi_info = { > + .type = "J606F BOE", > + .channel = 0, > + .node = NULL, > + }, The dsi_info just be used to register slave dsi, for single dsi case, can drop it. Otherwise looks great, thanks! Reviewed-by: Jianhua Lu <lujianhua000@gmail.com> > + .width_mm = 143, > + .height_mm = 235, > + .bpc = 8, > + .lanes = 4, > + .format = MIPI_DSI_FMT_RGB888, > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM, > + .init_sequence = j606f_boe_init_sequence, > + .has_dcs_backlight = true, > +}; > + > static void nt36523_reset(struct panel_info *pinfo) > { > gpiod_set_value_cansleep(pinfo->reset_gpio, 1); > @@ -826,6 +1313,10 @@ static int nt36523_probe(struct mipi_dsi_device *dsi) > } > > static const struct of_device_id nt36523_of_match[] = { > + { > + .compatible = "lenovo,j606f-boe-nt36523w", > + .data = &j606f_boe_desc, > + }, > { > .compatible = "xiaomi,elish-boe-nt36523", > .data = &elish_boe_desc, > > -- > 2.40.0 >
On Wed, Apr 12, 2023 at 9:46 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > This chip supports controlling the backlight via DCS commands, on at > least some panels. Add support for doing so. > > Note this may only concern the NT36523*W* variant. Nobody knows, really, > there's no docs. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
I added Novatek contact email to responders. Hi Novatek, can we have a public datasheet for NT36523? We are developing a Linux driver for NT36523-based displays and we need documentation. Thanks. On Wed, Apr 12, 2023 at 9:46 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3 > video mode display. Add support for these panels. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Thanks for the best effort to use documented commands and best guesses for defines. The rest we can detail if we ever run into a datasheet. Novatek doesn't have a single email address in the kernel log so no idea who I could mail about this, I think I even tried their webpage at one point, no answer. But I put their contact mail on the To-line let's see if someone answers! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Continuation of: https://lore.kernel.org/lkml/20230217-topic-lenovo-panel-v2-0-2e2c64729330@linaro.org/ I rolled back the versioning, as this has been remade from scratch. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Konrad Dybcio (5): dt-bindings: display: panel: nt36523: Allow 'port' instead of 'ports' dt-bindings: display: panel: nt36523: Add Lenovo J606F panel drm/panel: nt36523: Add DCS backlight support drm/panel: nt36523: Get orientation from OF drm/panel: nt36523: Add Lenovo J606F panel .../bindings/display/panel/novatek,nt36523.yaml | 31 +- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 573 ++++++++++++++++++++- 2 files changed, 594 insertions(+), 10 deletions(-) --- base-commit: 7d8214bba44c1aa6a75921a09a691945d26a8d43 change-id: 20230412-topic-lenovopanel-0d3a057e3c23 Best regards,