| Message ID | 20230407021343.63512-1-jiapeng.chong@linux.alibaba.com |
|---|---|
| State | Accepted |
| Commit | cd7cd6f386df21725eeab5d803226d4f74177203 |
| Headers | show |
| Series | [v2] Input: cma3000_d0x - Remove duplicate code | expand |
On Fri, Apr 07, 2023 at 10:13:43AM +0800, Jiapeng Chong wrote: > Function input_set_abs_params() has already set EV_ABS bit for us. > > drivers/input/misc/cma3000_d0x.c:328 cma3000_init() warn: inconsistent indenting. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4588 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Applied, thank you.
diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c index e6feb73bb52b..1772846708d2 100644 --- a/drivers/input/misc/cma3000_d0x.c +++ b/drivers/input/misc/cma3000_d0x.c @@ -325,8 +325,6 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq, input_dev->open = cma3000_open; input_dev->close = cma3000_close; - __set_bit(EV_ABS, input_dev->evbit); - input_set_abs_params(input_dev, ABS_X, -data->g_range, data->g_range, pdata->fuzz_x, 0); input_set_abs_params(input_dev, ABS_Y,
Function input_set_abs_params() has already set EV_ABS bit for us. drivers/input/misc/cma3000_d0x.c:328 cma3000_init() warn: inconsistent indenting. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4588 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v2: -Remove __set_bit(EV_ABS, input_dev->evbit); drivers/input/misc/cma3000_d0x.c | 2 -- 1 file changed, 2 deletions(-)