mbox series

[0/2] Fixes for rk817_charger driver

Message ID 20230407161827.127473-1-macroalpha82@gmail.com
Headers show
Series Fixes for rk817_charger driver | expand

Message

Chris Morgan April 7, 2023, 4:18 p.m. UTC
From: Chris Morgan <macromorgan@hotmail.com>

After using the driver for a few months I noticed a few issues that
this patch series seeks to address. Namely, there appears to be some
left over code that was used for debugging during development that is
no longer needed. Additionally, when the state of charge drops to 0
there is an issue with reading the value on boot because the columb
counter appears to hold a signed value.

With these fixes in place the battery driver appears to operate better
and without the odd bug of an unsigned integer overflow on the columb
counter.

Chris Morgan (2):
  power: supply: Remove unneeded code in rk817_charger
  power: supply: Fix low SOC bugs in rk817 driver

 drivers/power/supply/rk817_charger.c | 48 ++++++++++++++++------------
 1 file changed, 28 insertions(+), 20 deletions(-)

Comments

Sebastian Reichel April 7, 2023, 10:36 p.m. UTC | #1
Hi,

On Fri, Apr 07, 2023 at 11:18:25AM -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> After using the driver for a few months I noticed a few issues that
> this patch series seeks to address. Namely, there appears to be some
> left over code that was used for debugging during development that is
> no longer needed. Additionally, when the state of charge drops to 0
> there is an issue with reading the value on boot because the columb
> counter appears to hold a signed value.
> 
> With these fixes in place the battery driver appears to operate better
> and without the odd bug of an unsigned integer overflow on the columb
> counter.
> 
> Chris Morgan (2):
>   power: supply: Remove unneeded code in rk817_charger
>   power: supply: Fix low SOC bugs in rk817 driver
> 
>  drivers/power/supply/rk817_charger.c | 48 ++++++++++++++++------------
>  1 file changed, 28 insertions(+), 20 deletions(-)

Thanks, queued.

-- Sebastian