Message ID | 1398172475-27873-17-git-send-email-julien.grall@linaro.org |
---|---|
State | Superseded, archived |
Headers | show |
>>> On 22.04.14 at 15:14, <julien.grall@linaro.org> wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -134,6 +134,7 @@ F: xen/drivers/char/dt-uart.c > F: xen/drivers/char/exynos4210-uart.c > F: xen/drivers/char/omap-uart.c > F: xen/drivers/char/pl011.c > +F: xen/drivers/passthrough/arm This needs a trailing slash, I think. Jan
Hi Jan, On 04/22/2014 02:50 PM, Jan Beulich wrote: >>>> On 22.04.14 at 15:14, <julien.grall@linaro.org> wrote: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -134,6 +134,7 @@ F: xen/drivers/char/dt-uart.c >> F: xen/drivers/char/exynos4210-uart.c >> F: xen/drivers/char/omap-uart.c >> F: xen/drivers/char/pl011.c >> +F: xen/drivers/passthrough/arm > > This needs a trailing slash, I think. The trailing is not necessary (it works correctly for me). I can add it for consistency. While I was testing this patch, I've noticed that get_maintainer.pl is considering that you maintain the directory passthrough/arm with Ian C., Stefano and Tim.
>>> On 22.04.14 at 17:02, <julien.grall@linaro.org> wrote: > On 04/22/2014 02:50 PM, Jan Beulich wrote: >>>>> On 22.04.14 at 15:14, <julien.grall@linaro.org> wrote: >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -134,6 +134,7 @@ F: xen/drivers/char/dt-uart.c >>> F: xen/drivers/char/exynos4210-uart.c >>> F: xen/drivers/char/omap-uart.c >>> F: xen/drivers/char/pl011.c >>> +F: xen/drivers/passthrough/arm >> >> This needs a trailing slash, I think. > > The trailing is not necessary (it works correctly for me). I can add it > for consistency. Please do, to clarify this is a directory. > While I was testing this patch, I've noticed that get_maintainer.pl is > considering that you maintain the directory passthrough/arm with Ian C., > Stefano and Tim. Likely because you don't also add X: xen/drivers/passthrough/arm/ to the generic IOMMU section. Jan
On 04/22/2014 05:35 PM, Jan Beulich wrote: >>>> On 22.04.14 at 17:02, <julien.grall@linaro.org> wrote: >> On 04/22/2014 02:50 PM, Jan Beulich wrote: >>>>>> On 22.04.14 at 15:14, <julien.grall@linaro.org> wrote: >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -134,6 +134,7 @@ F: xen/drivers/char/dt-uart.c >>>> F: xen/drivers/char/exynos4210-uart.c >>>> F: xen/drivers/char/omap-uart.c >>>> F: xen/drivers/char/pl011.c >>>> +F: xen/drivers/passthrough/arm >>> >>> This needs a trailing slash, I think. >> >> The trailing is not necessary (it works correctly for me). I can add it >> for consistency. > > Please do, to clarify this is a directory. > >> While I was testing this patch, I've noticed that get_maintainer.pl is >> considering that you maintain the directory passthrough/arm with Ian C., >> Stefano and Tim. > > Likely because you don't also add > > X: xen/drivers/passthrough/arm/ > > to the generic IOMMU section. Thanks, I use it in the next version.
diff --git a/MAINTAINERS b/MAINTAINERS index 3508f18..4ebb966 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -134,6 +134,7 @@ F: xen/drivers/char/dt-uart.c F: xen/drivers/char/exynos4210-uart.c F: xen/drivers/char/omap-uart.c F: xen/drivers/char/pl011.c +F: xen/drivers/passthrough/arm CPU POOLS M: Juergen Gross <juergen.gross@ts.fujitsu.com>