| Message ID | 20230403160329.707176-1-hdegoede@redhat.com |
|---|---|
| Headers | show |
| Series | ACPI: video: Fix missing acpi_video# devices on some systems | expand |
On 4/3/2023 11:03, Hans de Goede wrote: > Hi Rafael, > > This patch series consists of 2 parts: > > 1. Fix missing acpi_video# devices on some systems, currently in kernels > >= 6.1.5 and >= 6.2.0 acpi_video# backlight class devices will only > get registered (by default) when a GPU driver asks for this by calling > acpi_video_register_backlight(). This is causing backlight control to > be missing on some systems. > > Patches 1-4 fix this and ideally these should be send to Linus for > an upcoming 6.3-rc# release. > > 2. Now that the dust has settled a bit on the backlight refactor we can > do some further cleanups. This is done in patches 5 + 6. Note that > patch 5 depends on patch 2. > > Regards, > > Hans > > > Hans de Goede (6): > ACPI: video: Add auto_detect arg to __acpi_video_get_backlight_type() > ACPI: video: Make acpi_backlight=video work independent from GPU > driver > ACPI: video: Add acpi_backlight=video quirk for Apple iMac14,1 and > iMac14,2 > ACPI: video: Add acpi_backlight=video quirk for Lenovo ThinkPad W530 > ACPI: video: Remove register_backlight_delay module option and code > ACPI: video: Remove desktops without backlight DMI quirks > > drivers/acpi/acpi_video.c | 53 +++-------- > drivers/acpi/video_detect.c | 87 ++++++++++--------- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 - > include/acpi/video.h | 17 +++- > 4 files changed, 71 insertions(+), 90 deletions(-) > One minor nit on a patch, otherwise: Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Hi, On 4/3/23 18:41, Limonciello, Mario wrote: > On 4/3/2023 11:03, Hans de Goede wrote: >> Hi Rafael, >> >> This patch series consists of 2 parts: >> >> 1. Fix missing acpi_video# devices on some systems, currently in kernels >> >= 6.1.5 and >= 6.2.0 acpi_video# backlight class devices will only >> get registered (by default) when a GPU driver asks for this by calling >> acpi_video_register_backlight(). This is causing backlight control to >> be missing on some systems. >> >> Patches 1-4 fix this and ideally these should be send to Linus for >> an upcoming 6.3-rc# release. >> >> 2. Now that the dust has settled a bit on the backlight refactor we can >> do some further cleanups. This is done in patches 5 + 6. Note that >> patch 5 depends on patch 2. >> >> Regards, >> >> Hans >> >> >> Hans de Goede (6): >> ACPI: video: Add auto_detect arg to __acpi_video_get_backlight_type() >> ACPI: video: Make acpi_backlight=video work independent from GPU >> driver >> ACPI: video: Add acpi_backlight=video quirk for Apple iMac14,1 and >> iMac14,2 >> ACPI: video: Add acpi_backlight=video quirk for Lenovo ThinkPad W530 >> ACPI: video: Remove register_backlight_delay module option and code >> ACPI: video: Remove desktops without backlight DMI quirks >> >> drivers/acpi/acpi_video.c | 53 +++-------- >> drivers/acpi/video_detect.c | 87 ++++++++++--------- >> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 - >> include/acpi/video.h | 17 +++- >> 4 files changed, 71 insertions(+), 90 deletions(-) >> > > One minor nit on a patch, otherwise: > > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Thank you. Rafael, can you fix up the typo in the commit msg of 5/6 while merging or do you want a new version ? Regards, Hans
Hi, On 4/4/23 11:52, Hans de Goede wrote: > Hi, > > On 4/3/23 18:41, Limonciello, Mario wrote: >> On 4/3/2023 11:03, Hans de Goede wrote: >>> Hi Rafael, >>> >>> This patch series consists of 2 parts: >>> >>> 1. Fix missing acpi_video# devices on some systems, currently in kernels >>> >= 6.1.5 and >= 6.2.0 acpi_video# backlight class devices will only >>> get registered (by default) when a GPU driver asks for this by calling >>> acpi_video_register_backlight(). This is causing backlight control to >>> be missing on some systems. >>> >>> Patches 1-4 fix this and ideally these should be send to Linus for >>> an upcoming 6.3-rc# release. >>> >>> 2. Now that the dust has settled a bit on the backlight refactor we can >>> do some further cleanups. This is done in patches 5 + 6. Note that >>> patch 5 depends on patch 2. >>> >>> Regards, >>> >>> Hans >>> >>> >>> Hans de Goede (6): >>> ACPI: video: Add auto_detect arg to __acpi_video_get_backlight_type() >>> ACPI: video: Make acpi_backlight=video work independent from GPU >>> driver >>> ACPI: video: Add acpi_backlight=video quirk for Apple iMac14,1 and >>> iMac14,2 >>> ACPI: video: Add acpi_backlight=video quirk for Lenovo ThinkPad W530 >>> ACPI: video: Remove register_backlight_delay module option and code >>> ACPI: video: Remove desktops without backlight DMI quirks >>> >>> drivers/acpi/acpi_video.c | 53 +++-------- >>> drivers/acpi/video_detect.c | 87 ++++++++++--------- >>> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 - >>> include/acpi/video.h | 17 +++- >>> 4 files changed, 71 insertions(+), 90 deletions(-) >>> >> >> One minor nit on a patch, otherwise: >> >> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > > Thank you. > > Rafael, can you fix up the typo in the commit msg of 5/6 > while merging or do you want a new version ? I just noticed this caused by 6/6, which I somehow missed before: CC [M] drivers/acpi/video_detect.o drivers/acpi/video_detect.c:133:12: warning: ‘video_detect_force_none’ defined but not used [-Wunused-function] 133 | static int video_detect_force_none(const struct dmi_system_id *d) | ^~~~~~~~~~~~~~~~~~~~~~~ So I need to prepare a new version to fix this. I'll also take care of fixing the commit msg of 5/6 in v2. Regards, Hans
Hi Rafael, This patch series consists of 2 parts: 1. Fix missing acpi_video# devices on some systems, currently in kernels >= 6.1.5 and >= 6.2.0 acpi_video# backlight class devices will only get registered (by default) when a GPU driver asks for this by calling acpi_video_register_backlight(). This is causing backlight control to be missing on some systems. Patches 1-4 fix this and ideally these should be send to Linus for an upcoming 6.3-rc# release. 2. Now that the dust has settled a bit on the backlight refactor we can do some further cleanups. This is done in patches 5 + 6. Note that patch 5 depends on patch 2. Regards, Hans Hans de Goede (6): ACPI: video: Add auto_detect arg to __acpi_video_get_backlight_type() ACPI: video: Make acpi_backlight=video work independent from GPU driver ACPI: video: Add acpi_backlight=video quirk for Apple iMac14,1 and iMac14,2 ACPI: video: Add acpi_backlight=video quirk for Lenovo ThinkPad W530 ACPI: video: Remove register_backlight_delay module option and code ACPI: video: Remove desktops without backlight DMI quirks drivers/acpi/acpi_video.c | 53 +++-------- drivers/acpi/video_detect.c | 87 ++++++++++--------- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 - include/acpi/video.h | 17 +++- 4 files changed, 71 insertions(+), 90 deletions(-)