[PATCHv1,0/3] generic-ohci/ehci: add RK3588 support

Hi,

This increases the max. allowed clocks for generic-ohci from 3 to 4.
On RK3588 a total of 4 clocks is required to access the OHCI registers.
EHCI already supports 4 clocks.

Changes since PATCHv1:
 * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/
 * Add Alan's Acked-by to the driver patch increasing the clock count
 * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles

-- Sebastian

Sebastian Reichel (3):
  dt-bindings: usb: Add RK3588 OHCI
  dt-bindings: usb: Add RK3588 EHCI
  usb: host: ohci-platform: increase max clock number to 4

 .../devicetree/bindings/usb/generic-ehci.yaml  |  1 +
 .../devicetree/bindings/usb/generic-ohci.yaml  | 18 ++++++++++++++++--
 drivers/usb/host/ohci-platform.c               |  2 +-
 3 files changed, 18 insertions(+), 3 deletions(-)

On 04/04/2023 16:53, Sebastian Reichel wrote:
> Add compatible for RK3588 EHCI. As far as I know it's fully
> compatible with generic-ehci.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

On 06/04/2023 12:51, Sebastian Reichel wrote:
> Hi Krzysztof,
> 
> On Thu, Apr 06, 2023 at 09:45:11AM +0200, Krzysztof Kozlowski wrote:
>> On 04/04/2023 16:53, Sebastian Reichel wrote:
>>> Add compatible for RK3588 OHCI. As far as I know it's fully
>>> compatible with generic-ohci.
>>>
>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>>> ---
>>>  .../devicetree/bindings/usb/generic-ohci.yaml  | 18 ++++++++++++++++--
>>>  1 file changed, 16 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
>>> index a9ba7257b884..d84732a100ba 100644
>>> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
>>> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
>>> @@ -44,6 +44,7 @@ properties:
>>>                - hpe,gxp-ohci
>>>                - ibm,476gtr-ohci
>>>                - ingenic,jz4740-ohci
>>> +              - rockchip,rk3588-ohci
>>>                - snps,hsdk-v1.0-ohci
>>>            - const: generic-ohci
>>>        - enum:
>>> @@ -68,8 +69,6 @@ properties:
>>>      maxItems: 2
>>>  
>>>    clocks:
>>> -    minItems: 1
>>> -    maxItems: 3
>>
>> The constraints here should stay.
> 
> dtbs_check complained about the 4 RK3588 clock entries if this
> stays. That's why I moved them to the condition down below into
> the else branch.

Which is not what we want. We want the constraints here (the widest).

Best regards,
Krzysztof

Hi,

On Thu, Apr 06, 2023 at 01:02:44PM +0200, Krzysztof Kozlowski wrote:
> On 06/04/2023 12:51, Sebastian Reichel wrote:
> >>>    clocks:
> >>> -    minItems: 1
> >>> -    maxItems: 3
> >>
> >> The constraints here should stay.
> > 
> > dtbs_check complained about the 4 RK3588 clock entries if this
> > stays. That's why I moved them to the condition down below into
> > the else branch.
> 
> Which is not what we want. We want the constraints here (the widest).

So it should look like this?

clocks:
    minItems: 1
    maxItems: 4

...

if rk3588:
    clocks:
        minItems: 4
        maxItems: 4
else:
    clocks:
        minItems: 1
        maxItems: 3

-- Sebastian