| Message ID | 20230403094017.9556-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | clocksource/drivers/exynos_mct: explicitly return 0 for shared timer | expand |
On 03/04/2023 11:40, Krzysztof Kozlowski wrote: > For a shared timers, the mct_init_dt() should not initialize the clock > even with global comparator. This is not an error, thus the function > should simply return 0, not 'ret'. > > This also fixes smatch warning: > > drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret' > > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <error27@gmail.com> > Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@intel.com/ > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Applied, thanks
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c index bfd60093ee1c..ef8cb1b71be4 100644 --- a/drivers/clocksource/exynos_mct.c +++ b/drivers/clocksource/exynos_mct.c @@ -677,17 +677,17 @@ static int __init mct_init_dt(struct device_node *np, unsigned int int_type) if (ret) return ret; /* * When the FRC is shared with a main processor, this secondary * processor cannot use the global comparator. */ if (frc_shared) - return ret; + return 0; return exynos4_clockevent_init(); } static int __init mct_init_spi(struct device_node *np) { return mct_init_dt(np, MCT_INT_SPI);
For a shared timers, the mct_init_dt() should not initialize the clock even with global comparator. This is not an error, thus the function should simply return 0, not 'ret'. This also fixes smatch warning: drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret' Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@intel.com/ Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/clocksource/exynos_mct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)