| Message ID | 20230405201219.2197811-1-oswald.buddenhagen@gmx.de |
|---|---|
| State | Accepted |
| Commit | e98e7a82bca2b6dce3e03719cff800ec913f9af7 |
| Headers | show |
| Series | ALSA: i2c/cs8427: fix iec958 mixer control deactivation | expand |
On Wed, 05 Apr 2023 22:12:19 +0200, Oswald Buddenhagen wrote: > > snd_cs8427_iec958_active() would always delete > SNDRV_CTL_ELEM_ACCESS_INACTIVE, even though the function has an > argument `active`. > > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Thanks, applied. Takashi
diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c index 65012af6a36e..f58b14b49045 100644 --- a/sound/i2c/cs8427.c +++ b/sound/i2c/cs8427.c @@ -561,10 +561,13 @@ int snd_cs8427_iec958_active(struct snd_i2c_device *cs8427, int active) if (snd_BUG_ON(!cs8427)) return -ENXIO; chip = cs8427->private_data; - if (active) + if (active) { memcpy(chip->playback.pcm_status, chip->playback.def_status, 24); - chip->playback.pcm_ctl->vd[0].access &= ~SNDRV_CTL_ELEM_ACCESS_INACTIVE; + chip->playback.pcm_ctl->vd[0].access &= ~SNDRV_CTL_ELEM_ACCESS_INACTIVE; + } else { + chip->playback.pcm_ctl->vd[0].access |= SNDRV_CTL_ELEM_ACCESS_INACTIVE; + } snd_ctl_notify(cs8427->bus->card, SNDRV_CTL_EVENT_MASK_VALUE | SNDRV_CTL_EVENT_MASK_INFO, &chip->playback.pcm_ctl->id);
snd_cs8427_iec958_active() would always delete SNDRV_CTL_ELEM_ACCESS_INACTIVE, even though the function has an argument `active`. Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> --- sound/i2c/cs8427.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)