| Message ID | 20230203-evk-board-support-v3-0-0003e80e0095@baylibre.com |
|---|---|
| Headers | show |
| Series | Improve the MT8365 SoC and EVK board support | expand |
Il 29/03/23 10:54, Alexandre Mergnat ha scritto: > Add binding description for mediatek,mt8365-wdt > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 29/03/23 10:54, Alexandre Mergnat ha scritto: > This power management system chip integration helps to manage regulators > and keys. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > index fc7f6d8ae173..2f88562c638a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > @@ -12,6 +12,7 @@ > #include <dt-bindings/input/input.h> > #include <dt-bindings/pinctrl/mt8365-pinfunc.h> > #include "mt8365.dtsi" > +#include "mt6357.dtsi" > > / { > model = "MediaTek MT8365 Open Platform EVK"; > @@ -96,6 +97,13 @@ &i2c0 { > #size-cells = <0>; > }; > > +&mt6357_pmic { > + interrupt-parent = <&pio>; > + interrupts = <145 IRQ_TYPE_LEVEL_HIGH>; Please... use: interrupts-extended = <&pio 145 IRQ_TYPE_LEVEL_HIGH>; Cheers, Angelo
Il 29/03/23 10:54, Alexandre Mergnat ha scritto: > - Add EMMC support on mmc0 (internal memory) > - Add SD-UHS support on mmc1 (external memory) > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 138 ++++++++++++++++++++++++++++ > 1 file changed, 138 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > index 2f88562c638a..b5d018686cbe 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > @@ -97,6 +97,42 @@ &i2c0 { > #size-cells = <0>; > }; > > +&mmc0 { > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc0_default_pins>; > + pinctrl-1 = <&mmc0_uhs_pins>; > + bus-width = <8>; > + max-frequency = <200000000>; > + cap-mmc-highspeed; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + cap-mmc-hw-reset; > + no-sdio; > + no-sd; > + hs400-ds-delay = <0x12012>; > + vmmc-supply = <&mt6357_vemc_reg>; > + vqmmc-supply = <&mt6357_vio18_reg>; > + assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL>; > + non-removable; That's a bit messy :-) Can we please reorder this by name? assigned-clocks.... bus-width cap.... hs400-ds-delay max... mmc-hs... no... non-rem... pinctrl... vxxxx-supply status .... ...Actually the same comment also applies to mmc1. Cheers, Angelo
Il 29/03/23 10:54, Alexandre Mergnat ha scritto: > This patch add support for SuperSpeed USB, in OTG mode, on micro connector. > It also add support for the Extensible Host Controller Interface USB. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > index 22ec332fe9c9..868ee0d160e4 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > @@ -319,6 +319,28 @@ &pwm { > status = "okay"; > }; > > +&ssusb { > + pinctrl-0 = <&usb_pins>; > + pinctrl-names = "default"; > + maximum-speed = "high-speed"; > + usb-role-switch; > + dr_mode = "otg"; > + vusb33-supply = <&mt6357_vusb33_reg>; > + status = "okay"; Order by name please. P.S.: status can go at the bottom, even if v < s :-) Thanks, Angelo
Il 29/03/23 10:54, Alexandre Mergnat ha scritto: > In order to have cpufreq support, this patch adds generic Operating > Performance Points support. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt8365.dtsi | 85 ++++++++++++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > index 394a5a61be59..c3ea3cc97a47 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > @@ -20,6 +20,75 @@ cpus { > #address-cells = <1>; > #size-cells = <0>; > > + cluster0_opp: opp-table-0 { > + compatible = "operating-points-v2"; > + opp-shared; One blank line here please, makes it slightly more readable. > + opp-850000000 { > + opp-hz = /bits/ 64 <850000000>; > + opp-microvolt = <650000>; > + }; Also, my personal preference is to also leave a blank line between each opp-xxxx subnode, but that's your choice. Everything else looks good.
Alexandre Mergnat <amergnat@baylibre.com> writes: > This commits are based on the Fabien Parent <fparent@baylibre.com> work. > > The purpose of this series is to add the following HWs / IPs support for > the mt8365-evk board: > - Watchdog > - Power Management Integrated Circuit "PMIC" wrapper > - MT6357 PMIC > - MultiMediaCard "MMC" & Secure Digital "SD" controller > - USB controller > - Ethernet MAC controller > > Add CPU Freq & IDLE support for this board. > > This series depends to another one which add support for MT8365 SoC and > EVK board [1]. It seems to depend on more than that series. In order to test this, I tried applying this series on top of Bero's minimal support (now in linux-next), and it does not apply cleanly. Could you please list all the dependencies that are not yet upstream. Thanks, Kevin
Le jeu. 30 mars 2023 à 02:09, Kevin Hilman <khilman@baylibre.com> a écrit : > > Alexandre Mergnat <amergnat@baylibre.com> writes: > > > This commits are based on the Fabien Parent <fparent@baylibre.com> work. > > > > The purpose of this series is to add the following HWs / IPs support for > > the mt8365-evk board: > > - Watchdog > > - Power Management Integrated Circuit "PMIC" wrapper > > - MT6357 PMIC > > - MultiMediaCard "MMC" & Secure Digital "SD" controller > > - USB controller > > - Ethernet MAC controller > > > > Add CPU Freq & IDLE support for this board. > > > > This series depends to another one which add support for MT8365 SoC and > > EVK board [1]. > > It seems to depend on more than that series. In order to test this, I > tried applying this series on top of Bero's minimal support (now in > linux-next), and it does not apply cleanly. > > Could you please list all the dependencies that are not yet upstream. Hi Kevin, You're right, it also depend to https://lore.kernel.org/all/20221122-mt8365-i2c-support-v6-0-e1009c8afd53@baylibre.com/ Regards, Alex
On 29/03/2023 10:54, Alexandre Mergnat wrote: > Add binding description for mediatek,mt8365-wdt > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml > index 55b34461df1b..66cacea8e47f 100644 > --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml > @@ -38,6 +38,7 @@ properties: > - mediatek,mt7623-wdt > - mediatek,mt7629-wdt > - mediatek,mt8173-wdt > + - mediatek,mt8365-wdt > - mediatek,mt8516-wdt > - const: mediatek,mt6589-wdt > >
On 29/03/2023 15:17, AngeloGioacchino Del Regno wrote: > Il 29/03/23 10:54, amergnat@baylibre.com ha scritto: >> From: Fabien Parent <fparent@baylibre.com> >> >> This new device-tree add the regulators, rtc and keys support >> for the MT6357 PMIC. >> >> Signed-off-by: Fabien Parent <fparent@baylibre.com> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> >> --- >> arch/arm64/boot/dts/mediatek/mt6357.dtsi | 282 +++++++++++++++++++++++++++++++ >> 1 file changed, 282 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt6357.dtsi >> b/arch/arm64/boot/dts/mediatek/mt6357.dtsi >> new file mode 100644 >> index 000000000000..3330a03c2f74 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/mediatek/mt6357.dtsi >> @@ -0,0 +1,282 @@ > > ..snip.. > >> + >> + keys { >> + compatible = "mediatek,mt6357-keys"; >> + >> + key-power { >> + linux,keycodes = <KEY_POWER>; >> + wakeup-source; >> + }; >> + >> + key-home { >> + linux,keycodes = <KEY_HOME>; >> + wakeup-source; > > KEY_HOME is a wakeup-source?! are you sure?! I think it could make sense to do that, so I just queued the patch. If that was an oversight, then please send a follow-up patch. Regards, Matthias > > (P.S.: I'm just checking if that was intended) > > Regards, > Angelo
On 29/03/2023 15:26, AngeloGioacchino Del Regno wrote: > Il 29/03/23 10:54, Alexandre Mergnat ha scritto: >> This patch add support for SuperSpeed USB, in OTG mode, on micro connector. >> It also add support for the Extensible Host Controller Interface USB. >> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> >> --- >> arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts >> b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts >> index 22ec332fe9c9..868ee0d160e4 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts >> @@ -319,6 +319,28 @@ &pwm { >> status = "okay"; >> }; >> +&ssusb { >> + pinctrl-0 = <&usb_pins>; >> + pinctrl-names = "default"; >> + maximum-speed = "high-speed"; >> + usb-role-switch; >> + dr_mode = "otg"; >> + vusb33-supply = <&mt6357_vusb33_reg>; >> + status = "okay"; > > Order by name please. > > P.S.: status can go at the bottom, even if v < s :-) You mean v > s ;-) Yes please reorder keep the status to the bottom that's somehow identical throughout the kernel. Regards, Matthias > > Thanks, > Angelo
Alexandre Mergnat <amergnat@baylibre.com> writes: > Le jeu. 30 mars 2023 à 02:09, Kevin Hilman <khilman@baylibre.com> a écrit : >> >> Alexandre Mergnat <amergnat@baylibre.com> writes: >> >> > This commits are based on the Fabien Parent <fparent@baylibre.com> work. >> > >> > The purpose of this series is to add the following HWs / IPs support for >> > the mt8365-evk board: >> > - Watchdog >> > - Power Management Integrated Circuit "PMIC" wrapper >> > - MT6357 PMIC >> > - MultiMediaCard "MMC" & Secure Digital "SD" controller >> > - USB controller >> > - Ethernet MAC controller >> > >> > Add CPU Freq & IDLE support for this board. >> > >> > This series depends to another one which add support for MT8365 SoC and >> > EVK board [1]. >> >> It seems to depend on more than that series. In order to test this, I >> tried applying this series on top of Bero's minimal support (now in >> linux-next), and it does not apply cleanly. >> >> Could you please list all the dependencies that are not yet upstream. > > Hi Kevin, > You're right, it also depend to > https://lore.kernel.org/all/20221122-mt8365-i2c-support-v6-0-e1009c8afd53@baylibre.com/ Nope. Something else is missing too. I tried this series on top of Bero's series + i2c series and still doesn't apply cleanly. Look like some pinctrl stuff is also missing[1]. Kevin [1] Link: https://lore.kernel.org/r/20230203-evk-board-support-v3-0-0003e80e0095@baylibre.com Base: base-commit 555b3a55823ec063129de4403899203febb58788 not known, ignoring Base: not specified git am /ssd/work/tmp/b4.mbx Applying: dt-bindings: watchdog: mediatek,mtk-wdt: add mt8365 Applying: dt-bindings: pinctrl: mediatek,mt8365-pinctrl: add drive strength property error: Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml: does not exist in index Patch failed at 0002 dt-bindings: pinctrl: mediatek,mt8365-pinctrl: add drive strength property
Le mer. 29 mars 2023 à 15:17, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> a écrit : > > Il 29/03/23 10:54, amergnat@baylibre.com ha scritto: > > From: Fabien Parent <fparent@baylibre.com> > > > > This new device-tree add the regulators, rtc and keys support > > for the MT6357 PMIC. > > > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > --- > > arch/arm64/boot/dts/mediatek/mt6357.dtsi | 282 +++++++++++++++++++++++++++++++ > > 1 file changed, 282 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt6357.dtsi b/arch/arm64/boot/dts/mediatek/mt6357.dtsi > > new file mode 100644 > > index 000000000000..3330a03c2f74 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt6357.dtsi > > @@ -0,0 +1,282 @@ > > ..snip.. > > > + > > + keys { > > + compatible = "mediatek,mt6357-keys"; > > + > > + key-power { > > + linux,keycodes = <KEY_POWER>; > > + wakeup-source; > > + }; > > + > > + key-home { > > + linux,keycodes = <KEY_HOME>; > > + wakeup-source; > > KEY_HOME is a wakeup-source?! are you sure?! > > (P.S.: I'm just checking if that was intended) Yes it's the setup used in the official Mediatek Rity project. Regards, Alex
This commits are based on the Fabien Parent <fparent@baylibre.com> work. The purpose of this series is to add the following HWs / IPs support for the mt8365-evk board: - Watchdog - Power Management Integrated Circuit "PMIC" wrapper - MT6357 PMIC - MultiMediaCard "MMC" & Secure Digital "SD" controller - USB controller - Ethernet MAC controller Add CPU Freq & IDLE support for this board. This series depends to another one which add support for MT8365 SoC and EVK board [1]. Regards, Alex [1]: https://lore.kernel.org/all/20230125143503.1015424-1-bero@baylibre.com/ Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- Changes in v3: - Add trailers and simply resend. - Link to v2: https://lore.kernel.org/r/20230203-evk-board-support-v2-0-6ec7cdb10ccf@baylibre.com --- Alexandre Bailon (1): arm64: dts: mediatek: Increase the size BL31 reserved memory Alexandre Mergnat (12): dt-bindings: watchdog: mediatek,mtk-wdt: add mt8365 dt-bindings: pinctrl: mediatek,mt8365-pinctrl: add drive strength property arm64: dts: mediatek: add watchdog support for mt8365 SoC arm64: dts: mediatek: add pwrap support to mt8365 SoC arm64: dts: mediatek: add mt6357 PMIC support for mt8365-evk arm64: dts: mediatek: add mmc support for mt8365 SoC arm64: dts: mediatek: add mmc support for mt8365-evk arm64: dts: mediatek: add usb controller support for mt8365-evk arm64: dts: mediatek: add ethernet support for mt8365 SoC arm64: dts: mediatek: add ethernet support for mt8365-evk arm64: dts: mediatek: add OPP support for mt8365 SoC arm64: dts: mediatek: add cpufreq support for mt8365-evk Amjad Ouled-Ameur (2): arm64: dts: mediatek: fix systimer properties arm64: dts: mediatek: Add CPU Idle support Fabien Parent (2): arm64: dts: mediatek: add mt6357 device-tree arm64: dts: mediatek: set vmc regulator as always on .../bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 3 + .../bindings/watchdog/mediatek,mtk-wdt.yaml | 1 + arch/arm64/boot/dts/mediatek/mt6357.dtsi | 282 +++++++++++++++++++++ arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 254 ++++++++++++++++++- arch/arm64/boot/dts/mediatek/mt8365.dtsi | 196 +++++++++++++- 5 files changed, 731 insertions(+), 5 deletions(-) --- base-commit: 555b3a55823ec063129de4403899203febb58788 change-id: 20230203-evk-board-support-d5b7a839ed7b Best regards,