| Message ID | 4a21defe3320eb11d0e43bc7f02b3168ecefd458.1679909245.git.quic_varada@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Enable IPQ9754 USB | expand |
On Mon, Mar 27, 2023 at 01:02:52PM +0300, Dmitry Baryshkov wrote: > On 27/03/2023 12:30, Varadarajan Narayanan wrote: > >Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > > > >Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > >--- > > Changes in v4: > > - Remove constraints not applicable to IPQ9574 > > Changes in v3: > > - Update other mandatory fields to accomodate IPQ9574 > > Changes in v2: > > - Updated sections missed in previous patch > >--- > > .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 25 ++++++++++++++++++++-- > > 1 file changed, 23 insertions(+), 2 deletions(-) > > > >diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >index e81a382..aa5b58c 100644 > >--- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >+++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >@@ -21,6 +21,7 @@ properties: > > enum: > > - qcom,ipq6018-qmp-usb3-phy > > - qcom,ipq8074-qmp-usb3-phy > >+ - qcom,ipq9574-qmp-usb3-phy > > - qcom,msm8996-qmp-usb3-phy > > - qcom,msm8998-qmp-usb3-phy > > - qcom,qcm2290-qmp-usb3-phy > >@@ -122,8 +123,6 @@ required: > > - clock-names > > - resets > > - reset-names > >- - vdda-phy-supply > >- - vdda-pll-supply > > Same questions as for the qusb2 PHY. How is the PHY powered? It is powered by always on regulators. Will create fixed regulators and assign them to these. Thanks Varada > > additionalProperties: false > > -- > With best wishes > Dmitry >
On Tue, Mar 28, 2023 at 09:07:08AM +0200, Krzysztof Kozlowski wrote: > On 27/03/2023 11:30, Varadarajan Narayanan wrote: > > Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Changes in v4: > > - Remove constraints not applicable to IPQ9574 > > Changes in v3: > > - Update other mandatory fields to accomodate IPQ9574 > > Changes in v2: > > - Updated sections missed in previous patch > > --- > > .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 25 ++++++++++++++++++++-- > > 1 file changed, 23 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > index e81a382..aa5b58c 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > @@ -21,6 +21,7 @@ properties: > > enum: > > - qcom,ipq6018-qmp-usb3-phy > > - qcom,ipq8074-qmp-usb3-phy > > + - qcom,ipq9574-qmp-usb3-phy > > - qcom,msm8996-qmp-usb3-phy > > - qcom,msm8998-qmp-usb3-phy > > - qcom,qcm2290-qmp-usb3-phy > > @@ -122,8 +123,6 @@ required: > > - clock-names > > - resets > > - reset-names > > - - vdda-phy-supply > > - - vdda-pll-supply > > > > additionalProperties: false > > > > @@ -204,6 +203,28 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,ipq9574-qmp-usb3-phy > > + then: > > + properties: > > + clocks: > > + maxItems: 3 > > + clock-names: > > + items: > > + - const: aux > > + - const: cfg_ahb > > + - const: pipe > > Isn't pipe the clock for child node? Will be moving to a newer style binding (as specified in qcom,sc8280xp-qmp-usb3-uni-phy.yaml). Will update accordingly and post the patch. Thanks Varada > Best regards, > Krzysztof >
On 30/03/2023 09:10, Varadarajan Narayanan wrote: > On Mon, Mar 27, 2023 at 01:02:52PM +0300, Dmitry Baryshkov wrote: >> On 27/03/2023 12:30, Varadarajan Narayanan wrote: >>> Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 >>> >>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >>> --- >>> Changes in v4: >>> - Remove constraints not applicable to IPQ9574 >>> Changes in v3: >>> - Update other mandatory fields to accomodate IPQ9574 >>> Changes in v2: >>> - Updated sections missed in previous patch >>> --- >>> .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 25 ++++++++++++++++++++-- >>> 1 file changed, 23 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> index e81a382..aa5b58c 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> @@ -21,6 +21,7 @@ properties: >>> enum: >>> - qcom,ipq6018-qmp-usb3-phy >>> - qcom,ipq8074-qmp-usb3-phy >>> + - qcom,ipq9574-qmp-usb3-phy >>> - qcom,msm8996-qmp-usb3-phy >>> - qcom,msm8998-qmp-usb3-phy >>> - qcom,qcm2290-qmp-usb3-phy >>> @@ -122,8 +123,6 @@ required: >>> - clock-names >>> - resets >>> - reset-names >>> - - vdda-phy-supply >>> - - vdda-pll-supply >> >> Same questions as for the qusb2 PHY. How is the PHY powered? > > It is powered by always on regulators. Will create fixed > regulators and assign them to these. always-on where? in DTS? Then it is not really related to this patch... or you meant always-on power domains? Yet still device has power supplies. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml index e81a382..aa5b58c 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml @@ -21,6 +21,7 @@ properties: enum: - qcom,ipq6018-qmp-usb3-phy - qcom,ipq8074-qmp-usb3-phy + - qcom,ipq9574-qmp-usb3-phy - qcom,msm8996-qmp-usb3-phy - qcom,msm8998-qmp-usb3-phy - qcom,qcm2290-qmp-usb3-phy @@ -122,8 +123,6 @@ required: - clock-names - resets - reset-names - - vdda-phy-supply - - vdda-pll-supply additionalProperties: false @@ -204,6 +203,28 @@ allOf: compatible: contains: enum: + - qcom,ipq9574-qmp-usb3-phy + then: + properties: + clocks: + maxItems: 3 + clock-names: + items: + - const: aux + - const: cfg_ahb + - const: pipe + resets: + maxItems: 2 + reset-names: + items: + - const: phy + - const: common + + - if: + properties: + compatible: + contains: + enum: - qcom,sm8150-qmp-usb3-phy - qcom,sm8150-qmp-usb3-uni-phy - qcom,sm8250-qmp-usb3-uni-phy
Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- Changes in v4: - Remove constraints not applicable to IPQ9574 Changes in v3: - Update other mandatory fields to accomodate IPQ9574 Changes in v2: - Updated sections missed in previous patch --- .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)