Message ID | 20230324133741.43408-1-rogerq@kernel.org |
---|---|
State | New |
Headers | show |
Series | dt-bindings: usb: tps6598x: make interrupts optional | expand |
Hi Heikki & Rob, On 24/03/2023 15:37, Roger Quadros wrote: > The driver can poll for interrupt status so interrupts > can be optional. It is still recommended to use the > interrupt line. Polling should only be used for debug > and prototyping. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > index 348a715d61f4..8c2db282735a 100644 > --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > @@ -35,8 +35,6 @@ properties: > required: > - compatible > - reg > - - interrupts > - - interrupt-names > > additionalProperties: true > We need this patch as well along with the driver changes [1] Could you please Ack. Thanks! [1] - https://lore.kernel.org/r/20230324131853.41102-1-rogerq@kernel.org cheers, -roger
On Wed, Mar 29, 2023 at 10:05:33AM +0300, Roger Quadros wrote: > Hi Heikki & Rob, > > On 24/03/2023 15:37, Roger Quadros wrote: > > The driver can poll for interrupt status so interrupts > > can be optional. It is still recommended to use the > > interrupt line. Polling should only be used for debug > > and prototyping. > > > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > > --- > > Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > > index 348a715d61f4..8c2db282735a 100644 > > --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > > +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > > @@ -35,8 +35,6 @@ properties: > > required: > > - compatible > > - reg > > - - interrupts > > - - interrupt-names > > > > additionalProperties: true > > > > We need this patch as well along with the driver changes [1] > Could you please Ack. Thanks! I can give my ack FWIW, but we should still wait for Rob. Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> thanks,
On Wed, Mar 29, 2023 at 10:05:33AM +0300, Roger Quadros wrote: > Hi Heikki & Rob, > > On 24/03/2023 15:37, Roger Quadros wrote: > > The driver can poll for interrupt status so interrupts > > can be optional. It is still recommended to use the > > interrupt line. Polling should only be used for debug > > and prototyping. > > > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > > --- > > Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > > index 348a715d61f4..8c2db282735a 100644 > > --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > > +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > > @@ -35,8 +35,6 @@ properties: > > required: > > - compatible > > - reg > > - - interrupts > > - - interrupt-names > > > > additionalProperties: true > > > > We need this patch as well along with the driver changes [1] > Could you please Ack. Thanks! If get_maintainers.pl had been properly used, then it probably would have been acked by Krzysztof already. Otherwise, it's in my queue if the DT list is copied. Acked-by: Rob Herring <robh@kernel.org> Rob
diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml index 348a715d61f4..8c2db282735a 100644 --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml @@ -35,8 +35,6 @@ properties: required: - compatible - reg - - interrupts - - interrupt-names additionalProperties: true
The driver can poll for interrupt status so interrupts can be optional. It is still recommended to use the interrupt line. Polling should only be used for debug and prototyping. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 -- 1 file changed, 2 deletions(-)