| Message ID | 1398080958-21677-2-git-send-email-chander.kashyap@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 04/21/2014 01:49 PM, Chander Kashyap wrote: > Exynos5420 is a big-little SoC from Samsung. It has 4 A15 and 4 A7 cores. > In order to use generic cpuidle-big-little driver, this patch adds Exynos5420 > specific check to initialize generic cpuidle driver. > > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> > Signed-off-by: Chander Kashyap <k.chander@samsung.com> > --- > drivers/cpuidle/Kconfig.arm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm > index 97ccc31..5244d87 100644 > --- a/drivers/cpuidle/Kconfig.arm > +++ b/drivers/cpuidle/Kconfig.arm > @@ -4,7 +4,7 @@ > > config ARM_BIG_LITTLE_CPUIDLE > bool "Support for ARM big.LITTLE processors" > - depends on ARCH_VEXPRESS_TC2_PM > + depends on ARCH_VEXPRESS_TC2_PM || SOC_EXYNOS5420 For the sake of consistency, I would prefer: depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS and let the current code (and future platform driver) to handle the loading of the driver. > select ARM_CPU_SUSPEND > select CPU_IDLE_MULTIPLE_DRIVERS > help >
Hi Daniel, On 22 April 2014 16:12, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > On 04/21/2014 01:49 PM, Chander Kashyap wrote: >> >> Exynos5420 is a big-little SoC from Samsung. It has 4 A15 and 4 A7 cores. >> In order to use generic cpuidle-big-little driver, this patch adds >> Exynos5420 >> specific check to initialize generic cpuidle driver. >> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> >> Signed-off-by: Chander Kashyap <k.chander@samsung.com> >> --- >> drivers/cpuidle/Kconfig.arm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm >> index 97ccc31..5244d87 100644 >> --- a/drivers/cpuidle/Kconfig.arm >> +++ b/drivers/cpuidle/Kconfig.arm >> @@ -4,7 +4,7 @@ >> >> config ARM_BIG_LITTLE_CPUIDLE >> bool "Support for ARM big.LITTLE processors" >> - depends on ARCH_VEXPRESS_TC2_PM >> + depends on ARCH_VEXPRESS_TC2_PM || SOC_EXYNOS5420 > > > For the sake of consistency, I would prefer: > > depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS Yes i will change it. Thanks > > and let the current code (and future platform driver) to handle the loading > of the driver. > > >> select ARM_CPU_SUSPEND >> select CPU_IDLE_MULTIPLE_DRIVERS >> help >> > > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog >
diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm index 97ccc31..5244d87 100644 --- a/drivers/cpuidle/Kconfig.arm +++ b/drivers/cpuidle/Kconfig.arm @@ -4,7 +4,7 @@ config ARM_BIG_LITTLE_CPUIDLE bool "Support for ARM big.LITTLE processors" - depends on ARCH_VEXPRESS_TC2_PM + depends on ARCH_VEXPRESS_TC2_PM || SOC_EXYNOS5420 select ARM_CPU_SUSPEND select CPU_IDLE_MULTIPLE_DRIVERS help