| Message ID | 20230317151508.1225282-1-longman@redhat.com |
|---|---|
| Headers | show |
| Series | cgroup/cpuset: Miscellaneous updates | expand |
On 3/28/23 09:40, Will Deacon wrote: > Hi Waiman, > > On Fri, Mar 17, 2023 at 11:15:04AM -0400, Waiman Long wrote: >> v2: >> - Add a new patch 1 that fixes a bug introduced by recent v6.2 commit >> 7a2127e66a00 ("cpuset: Call set_cpus_allowed_ptr() with appropriate >> mask for task"). >> - Make a small twist and additional comment to patch 2 ("cgroup/cpuset: >> Skip task update if hotplug doesn't affect current cpuset") as >> suggested by Michal. >> - Remove v1 patches 3/4 for now for further discussion. >> >> This patch series includes miscellaneous update to the cpuset and its >> testing code. > FWIW, this series also passes my asymmetric 32-bit tests. Thanks Will! Tejun, do you have time to take a look at this series, especially the first patch which is a fix that may need to go to stable? Cheers, Longman
On Fri, Mar 17, 2023 at 11:15:08AM -0400, Waiman Long wrote: > This patch makes the following minor updates to the cpuset partition > testing script test_cpuset_prs.sh. > > - Remove online_cpus function call as it will be called anyway on exit > in cleanup. > - Make the enabling of sched/verbose debugfs flag conditional on the > "-v" verbose option and set DELAY_FACTOR to 2 in this case as cpuset > partition operations are likely to be slowed down by enabling that. > > Signed-off-by: Waiman Long <longman@redhat.com> Applied 2-4 to cgroup/for-6.4. Thanks.
v2: - Add a new patch 1 that fixes a bug introduced by recent v6.2 commit 7a2127e66a00 ("cpuset: Call set_cpus_allowed_ptr() with appropriate mask for task"). - Make a small twist and additional comment to patch 2 ("cgroup/cpuset: Skip task update if hotplug doesn't affect current cpuset") as suggested by Michal. - Remove v1 patches 3/4 for now for further discussion. This patch series includes miscellaneous update to the cpuset and its testing code. Patch 1 fixes a bug caused by commit 7a2127e66a00 ("cpuset: Call set_cpus_allowed_ptr() with appropriate mask for task") in the partition handling code. This fix was verified by running the test_cpuset_prs.sh test. Patch 2 is for a hotplug optimization. Patch 3 is actually a follow-up of commit 3fb906e7fabb ("cgroup/cpuset: Don't filter offline CPUs in cpuset_cpus_allowed() for top cpuset tasks"). Patch 4 reduces verbosity when running test_cpuset_prs.sh test script unless explicitly enabled with the -v option. Waiman Long (4): cgroup/cpuset: Fix partition root's cpuset.cpus update bug cgroup/cpuset: Skip task update if hotplug doesn't affect current cpuset cgroup/cpuset: Include offline CPUs when tasks' cpumasks in top_cpuset are updated cgroup/cpuset: Minor updates to test_cpuset_prs.sh kernel/cgroup/cpuset.c | 38 +++++++++++++------ .../selftests/cgroup/test_cpuset_prs.sh | 25 ++++++------ 2 files changed, 41 insertions(+), 22 deletions(-)