diff mbox series

scsi: hpsa: Remove the unused variable transMethod

Message ID 20230317054940.86685-1-jiapeng.chong@linux.alibaba.com
State New
Headers show
Series scsi: hpsa: Remove the unused variable transMethod | expand

Commit Message

Jiapeng Chong March 17, 2023, 5:49 a.m. UTC 
Variable transMethod is not effectively used, so delete it.

drivers/scsi/hpsa.c:9478:16: warning: variable 'transMethod' set but not used.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4554
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/scsi/hpsa.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Martin K. Petersen March 24, 2023, 8:57 p.m. UTC | #1 
Jiapeng,

> Variable transMethod is not effectively used, so delete it.
>
> drivers/scsi/hpsa.c:9478:16: warning: variable 'transMethod' set but
> not used.

Applied to 6.4/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index fec7e17747f7..2f2b46a95102 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9475,8 +9475,6 @@  static void hpsa_free_performant_mode(struct ctlr_info *h)
 static int hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)
 {
 	u32 trans_support;
-	unsigned long transMethod = CFGTBL_Trans_Performant |
-					CFGTBL_Trans_use_short_tags;
 	int i, rc;
 
 	if (hpsa_simple_mode)
@@ -9488,14 +9486,10 @@  static int hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)
 
 	/* Check for I/O accelerator mode support */
 	if (trans_support & CFGTBL_Trans_io_accel1) {
-		transMethod |= CFGTBL_Trans_io_accel1 |
-				CFGTBL_Trans_enable_directed_msix;
 		rc = hpsa_alloc_ioaccel1_cmd_and_bft(h);
 		if (rc)
 			return rc;
 	} else if (trans_support & CFGTBL_Trans_io_accel2) {
-		transMethod |= CFGTBL_Trans_io_accel2 |
-				CFGTBL_Trans_enable_directed_msix;
 		rc = hpsa_alloc_ioaccel2_cmd_and_bft(h);
 		if (rc)
 			return rc;