| Message ID | 20230321145651.9118-1-peter.ujfalusi@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] ASoC: SOF: ipc4-control: Return on error in sof_ipc4_widget_kcontrol_setup() | expand |
On Tue, Mar 21, 2023 at 04:56:51PM +0200, Peter Ujfalusi wrote: > The patch adding the bytes control support moved the error check outside > of the list_for_each_entry() which was not correct as at the end of the > list_for_each_entry() the scontrol will no longer point where the error > happened, but it to the list head. > > Restore the original logic and return on the first error with the error > code. > > Fixes: a062c8899fed ("ASoC: SOF: ipc4-control: Add support for bytes control get and put") > Reported-by: Dan Carpenter <error27@gmail.com> > Link: https://lore.kernel.org/alsa-devel/6be945d2-40cb-46fb-67ba-ed3a19cddfa4@linux.intel.com/T/#t > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> > --- Awesome sauce! Thanks! regards, dan carpenter
On Tue, 21 Mar 2023 16:56:51 +0200, Peter Ujfalusi wrote: > The patch adding the bytes control support moved the error check outside > of the list_for_each_entry() which was not correct as at the end of the > list_for_each_entry() the scontrol will no longer point where the error > happened, but it to the list head. > > Restore the original logic and return on the first error with the error > code. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: ipc4-control: Return on error in sof_ipc4_widget_kcontrol_setup() commit: 1c12e032cc43256d75fdd22e60a7df85e8df4549 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/ipc4-control.c b/sound/soc/sof/ipc4-control.c index d26ed2a6029f..6f0698be9451 100644 --- a/sound/soc/sof/ipc4-control.c +++ b/sound/soc/sof/ipc4-control.c @@ -429,14 +429,17 @@ static int sof_ipc4_widget_kcontrol_setup(struct snd_sof_dev *sdev, struct snd_s default: break; } + + if (ret < 0) { + dev_err(sdev->dev, + "kcontrol %d set up failed for widget %s\n", + scontrol->comp_id, swidget->widget->name); + return ret; + } } } - if (ret < 0) - dev_err(sdev->dev, "kcontrol %d set up failed for widget %s\n", - scontrol->comp_id, swidget->widget->name); - - return ret; + return 0; } static int
The patch adding the bytes control support moved the error check outside of the list_for_each_entry() which was not correct as at the end of the list_for_each_entry() the scontrol will no longer point where the error happened, but it to the list head. Restore the original logic and return on the first error with the error code. Fixes: a062c8899fed ("ASoC: SOF: ipc4-control: Add support for bytes control get and put") Reported-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/alsa-devel/6be945d2-40cb-46fb-67ba-ed3a19cddfa4@linux.intel.com/T/#t Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> --- sound/soc/sof/ipc4-control.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)