| Message ID | 20230321183439.1826823-1-trix@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | watchdog: s3c2410: remove unused freq_to_wdt and s3c2410wdt_is_running functions | expand |
Hi Tom, On Tue, Mar 21, 2023 at 02:34:39PM -0400, Tom Rix wrote: > clang with W=1 reports > drivers/watchdog/s3c2410_wdt.c:311:35: error: unused function > 'freq_to_wdt' [-Werror,-Wunused-function] > static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb) > ^ > drivers/watchdog/s3c2410_wdt.c:446:19: error: unused function > 's3c2410wdt_is_running' [-Werror,-Wunused-function] > static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt) > ^ > These functions are not used, so remove them. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/watchdog/s3c2410_wdt.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > index 200ba236a72e..6394dda7a5dc 100644 > --- a/drivers/watchdog/s3c2410_wdt.c > +++ b/drivers/watchdog/s3c2410_wdt.c > @@ -308,11 +308,6 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt) > / S3C2410_WTCON_MAXDIV); > } > > -static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb) > -{ > - return container_of(nb, struct s3c2410_wdt, freq_transition); > -} > - > static int s3c2410wdt_disable_wdt_reset(struct s3c2410_wdt *wdt, bool mask) > { > const u32 mask_val = BIT(wdt->drv_data->mask_bit); > @@ -443,11 +438,6 @@ static int s3c2410wdt_start(struct watchdog_device *wdd) > return 0; > } > > -static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt) > -{ > - return readl(wdt->reg_base + S3C2410_WTCON) & S3C2410_WTCON_ENABLE; > -} > - there is only one instance where this can be actually used in the driver, but it's inside a dev_info, so no point having it around. Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Andi > static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, > unsigned int timeout) > { > -- > 2.27.0 >
On Tue, Mar 21, 2023 at 02:34:39PM -0400, Tom Rix wrote: > clang with W=1 reports > drivers/watchdog/s3c2410_wdt.c:311:35: error: unused function > 'freq_to_wdt' [-Werror,-Wunused-function] > static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb) > ^ > drivers/watchdog/s3c2410_wdt.c:446:19: error: unused function > 's3c2410wdt_is_running' [-Werror,-Wunused-function] > static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt) > ^ > These functions are not used, so remove them. > > Signed-off-by: Tom Rix <trix@redhat.com> > Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/s3c2410_wdt.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > index 200ba236a72e..6394dda7a5dc 100644 > --- a/drivers/watchdog/s3c2410_wdt.c > +++ b/drivers/watchdog/s3c2410_wdt.c > @@ -308,11 +308,6 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt) > / S3C2410_WTCON_MAXDIV); > } > > -static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb) > -{ > - return container_of(nb, struct s3c2410_wdt, freq_transition); > -} > - > static int s3c2410wdt_disable_wdt_reset(struct s3c2410_wdt *wdt, bool mask) > { > const u32 mask_val = BIT(wdt->drv_data->mask_bit); > @@ -443,11 +438,6 @@ static int s3c2410wdt_start(struct watchdog_device *wdd) > return 0; > } > > -static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt) > -{ > - return readl(wdt->reg_base + S3C2410_WTCON) & S3C2410_WTCON_ENABLE; > -} > - > static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, > unsigned int timeout) > {
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 200ba236a72e..6394dda7a5dc 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -308,11 +308,6 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt) / S3C2410_WTCON_MAXDIV); } -static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb) -{ - return container_of(nb, struct s3c2410_wdt, freq_transition); -} - static int s3c2410wdt_disable_wdt_reset(struct s3c2410_wdt *wdt, bool mask) { const u32 mask_val = BIT(wdt->drv_data->mask_bit); @@ -443,11 +438,6 @@ static int s3c2410wdt_start(struct watchdog_device *wdd) return 0; } -static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt) -{ - return readl(wdt->reg_base + S3C2410_WTCON) & S3C2410_WTCON_ENABLE; -} - static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, unsigned int timeout) {
clang with W=1 reports drivers/watchdog/s3c2410_wdt.c:311:35: error: unused function 'freq_to_wdt' [-Werror,-Wunused-function] static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb) ^ drivers/watchdog/s3c2410_wdt.c:446:19: error: unused function 's3c2410wdt_is_running' [-Werror,-Wunused-function] static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt) ^ These functions are not used, so remove them. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/watchdog/s3c2410_wdt.c | 10 ---------- 1 file changed, 10 deletions(-)