| Message ID | 20230321235102.3832417-1-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC] tests/qemu-iotests: serialise all the qemu-iotests | expand |
On 22/3/23 00:51, Alex Bennée wrote: > Something on OpenBSD fails with multiple tests running at once and > fiddling with J=1 on invocation just made everything else very slow. > > Based-on: 20230318114644.1340899-1-alex.bennee@linaro.org > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qemu-iotests/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build > index a162f683ef..d572205a60 100644 > --- a/tests/qemu-iotests/meson.build > +++ b/tests/qemu-iotests/meson.build > @@ -64,6 +64,7 @@ foreach format, speed: qemu_iotests_formats > depends: qemu_iotests_binaries, > env: qemu_iotests_env, > protocol: 'tap', > + is_parallel : false, Per the commit description, what about: is_parallel: targetos != 'openbsd', ? > timeout: 180, > suite: suites) > endforeach
On Tue, Mar 21, 2023 at 11:51:02PM +0000, Alex Bennée wrote: > Something on OpenBSD fails with multiple tests running at once and > fiddling with J=1 on invocation just made everything else very slow. > > Based-on: 20230318114644.1340899-1-alex.bennee@linaro.org > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qemu-iotests/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build > index a162f683ef..d572205a60 100644 > --- a/tests/qemu-iotests/meson.build > +++ b/tests/qemu-iotests/meson.build > @@ -64,6 +64,7 @@ foreach format, speed: qemu_iotests_formats > depends: qemu_iotests_binaries, > env: qemu_iotests_env, > protocol: 'tap', > + is_parallel : false, > timeout: 180, > suite: suites) > endforeach This will be a massive regression for all platforms though. The iotests run a few 100 tests. Previously the iotests harness was serialized against all other QEMU tests, but the individual iotests were all parallelized. With this proposed change all 100 individual iotests are serialized, both with each other, and with all other QEMU tests. With regards, Daniel
Daniel P. Berrangé <berrange@redhat.com> writes: > On Tue, Mar 21, 2023 at 11:51:02PM +0000, Alex Bennée wrote: >> Something on OpenBSD fails with multiple tests running at once and >> fiddling with J=1 on invocation just made everything else very slow. >> >> Based-on: 20230318114644.1340899-1-alex.bennee@linaro.org >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> Cc: Daniel P. Berrangé <berrange@redhat.com> >> --- >> tests/qemu-iotests/meson.build | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build >> index a162f683ef..d572205a60 100644 >> --- a/tests/qemu-iotests/meson.build >> +++ b/tests/qemu-iotests/meson.build >> @@ -64,6 +64,7 @@ foreach format, speed: qemu_iotests_formats >> depends: qemu_iotests_binaries, >> env: qemu_iotests_env, >> protocol: 'tap', >> + is_parallel : false, >> timeout: 180, >> suite: suites) >> endforeach > > This will be a massive regression for all platforms though. > > The iotests run a few 100 tests. Previously the iotests harness was > serialized against all other QEMU tests, but the individual iotests > were all parallelized. > > With this proposed change all 100 individual iotests are serialized, > both with each other, and with all other QEMU tests. What about Phillipe's suggestion of doing it just for openbsd? > > With regards, > Daniel
diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build index a162f683ef..d572205a60 100644 --- a/tests/qemu-iotests/meson.build +++ b/tests/qemu-iotests/meson.build @@ -64,6 +64,7 @@ foreach format, speed: qemu_iotests_formats depends: qemu_iotests_binaries, env: qemu_iotests_env, protocol: 'tap', + is_parallel : false, timeout: 180, suite: suites) endforeach
Something on OpenBSD fails with multiple tests running at once and fiddling with J=1 on invocation just made everything else very slow. Based-on: 20230318114644.1340899-1-alex.bennee@linaro.org Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Cc: Daniel P. Berrangé <berrange@redhat.com> --- tests/qemu-iotests/meson.build | 1 + 1 file changed, 1 insertion(+)