| Message ID | 20230316151018.v1.1.I9113bb4f444afc2c5cb19d1e96569e01ddbd8939@changeid |
|---|---|
| State | Accepted |
| Commit | 853c3e629079a07fb0c34a0bf9dab03fe52a839c |
| Headers | show |
| Series | [v1] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=730613 ---Test result--- Test Summary: CheckPatch PASS 0.67 seconds GitLint PASS 0.31 seconds SubjectPrefix PASS 0.10 seconds BuildKernel PASS 36.41 seconds CheckAllWarning PASS 39.52 seconds CheckSparse PASS 44.58 seconds CheckSmatch PASS 120.18 seconds BuildKernel32 PASS 35.12 seconds TestRunnerSetup PASS 502.67 seconds TestRunner_l2cap-tester PASS 18.73 seconds TestRunner_iso-tester PASS 20.16 seconds TestRunner_bnep-tester PASS 6.33 seconds TestRunner_mgmt-tester PASS 125.29 seconds TestRunner_rfcomm-tester PASS 10.05 seconds TestRunner_sco-tester PASS 9.41 seconds TestRunner_ioctl-tester PASS 11.05 seconds TestRunner_mesh-tester PASS 8.12 seconds TestRunner_smp-tester PASS 9.13 seconds TestRunner_userchan-tester PASS 6.71 seconds IncrementalBuild PASS 33.29 seconds --- Regards, Linux Bluetooth
Thanks for the reply! A new patch has been sent. Please take a look when available. Thanks, Howard On Thu, Mar 16, 2023 at 5:47 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote: > > Dear Howard, > > > Thank you for your patch. > > Am 16.03.23 um 08:10 schrieb Howard Chung: > > From: howardchung <howardchung@google.com> > > Please configure your full name: > > git config --global user.name "Howard Chung" > git commit -s --amend --author="Howard Chung <howardchung@google.com>" > > > The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable > > length argumenent. This patch adds right the field. > > argument > > Were you seeing actual problems? If so, please describe the test setup. > > > Reviewed-by: Archie Pusaka <apusaka@chromium.org> > > Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh") > > Signed-off-by: howardchung <howardchung@google.com> > > --- > > > > net/bluetooth/mgmt.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c > > index 39589f864ea7..249dc6777fb4 100644 > > --- a/net/bluetooth/mgmt.c > > +++ b/net/bluetooth/mgmt.c > > @@ -9357,7 +9357,8 @@ static const struct hci_mgmt_handler mgmt_handlers[] = { > > { add_ext_adv_data, MGMT_ADD_EXT_ADV_DATA_SIZE, > > HCI_MGMT_VAR_LEN }, > > { add_adv_patterns_monitor_rssi, > > - MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE }, > > + MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE, > > + HCI_MGMT_VAR_LEN }, > > { set_mesh, MGMT_SET_MESH_RECEIVER_SIZE, > > HCI_MGMT_VAR_LEN }, > > { mesh_features, MGMT_MESH_READ_FEATURES_SIZE }, > > Acked-by: Paul Menzel <pmenzel@molgen.mpg.de> > > > Kind regards, > > Paul
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 39589f864ea7..249dc6777fb4 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -9357,7 +9357,8 @@ static const struct hci_mgmt_handler mgmt_handlers[] = { { add_ext_adv_data, MGMT_ADD_EXT_ADV_DATA_SIZE, HCI_MGMT_VAR_LEN }, { add_adv_patterns_monitor_rssi, - MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE }, + MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE, + HCI_MGMT_VAR_LEN }, { set_mesh, MGMT_SET_MESH_RECEIVER_SIZE, HCI_MGMT_VAR_LEN }, { mesh_features, MGMT_MESH_READ_FEATURES_SIZE },