mbox series

[0/1] net: wireless: wcn36xx: Add support for pronto-v3

Message ID 20230311150647.22935-1-sireeshkodali1@gmail.com
Headers show
Series net: wireless: wcn36xx: Add support for pronto-v3 | expand

Message

Sireesh Kodali March 11, 2023, 3:06 p.m. UTC 
Hi,

Pronto-v3 is a WiFi remoteproc found on MSM8953 and other Qualcomm
platforms. Support for booting the remoteproc has already been merged,
however, due to a slight change in the register map between v2 and v3,
the wcn36xx driver does not work on pronot-v3. This patch updates the
register definitions to make wcn36xx work on pronto-v3 as well.

Regards,
Sireesh Kodali

Vladimir Lypak (1):
  net: wireless: ath: wcn36xx: add support for pronto-v3

 drivers/net/wireless/ath/wcn36xx/dxe.c     | 23 +++++++++++-----------
 drivers/net/wireless/ath/wcn36xx/dxe.h     |  4 ++--
 drivers/net/wireless/ath/wcn36xx/main.c    |  1 +
 drivers/net/wireless/ath/wcn36xx/wcn36xx.h |  1 +
 4 files changed, 16 insertions(+), 13 deletions(-)

Comments

Kalle Valo March 13, 2023, 5:52 a.m. UTC | #1 
Sireesh Kodali <sireeshkodali1@gmail.com> writes:

> From: Vladimir Lypak <vladimir.lypak@gmail.com>
>
> Pronto v3 has a different DXE address than prior Pronto versions. This
> patch changes the macro to return the correct register address based on
> the pronto version.
>
> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
> ---
>  drivers/net/wireless/ath/wcn36xx/dxe.c     | 23 +++++++++++-----------
>  drivers/net/wireless/ath/wcn36xx/dxe.h     |  4 ++--
>  drivers/net/wireless/ath/wcn36xx/main.c    |  1 +
>  drivers/net/wireless/ath/wcn36xx/wcn36xx.h |  1 +
>  4 files changed, 16 insertions(+), 13 deletions(-)

The title should be:

wifi: wcn36xx: add support for pronto-v3

I can fix that, no need to resend because of this.
Sireesh Kodali March 14, 2023, 3:55 a.m. UTC | #2 
On Mon Mar 13, 2023 at 11:22 AM IST, Kalle Valo wrote:
> Sireesh Kodali <sireeshkodali1@gmail.com> writes:
>
> > From: Vladimir Lypak <vladimir.lypak@gmail.com>
> >
> > Pronto v3 has a different DXE address than prior Pronto versions. This
> > patch changes the macro to return the correct register address based on
> > the pronto version.
> >
> > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
> > ---
> >  drivers/net/wireless/ath/wcn36xx/dxe.c     | 23 +++++++++++-----------
> >  drivers/net/wireless/ath/wcn36xx/dxe.h     |  4 ++--
> >  drivers/net/wireless/ath/wcn36xx/main.c    |  1 +
> >  drivers/net/wireless/ath/wcn36xx/wcn36xx.h |  1 +
> >  4 files changed, 16 insertions(+), 13 deletions(-)
>
> The title should be:
>
> wifi: wcn36xx: add support for pronto-v3
>
> I can fix that, no need to resend because of this.
>
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Thank you, I'll keep this in mind when submitting future patches
Loic Poulain March 14, 2023, 8:49 a.m. UTC | #3 
On Sat, 11 Mar 2023 at 16:07, Sireesh Kodali <sireeshkodali1@gmail.com> wrote:
>
> From: Vladimir Lypak <vladimir.lypak@gmail.com>
>
> Pronto v3 has a different DXE address than prior Pronto versions. This
> patch changes the macro to return the correct register address based on
> the pronto version.
>
> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>

Acked-by: Loic Poulain <loic.poulain@linaro.org>

Could you also submit a change for the new 'qcom,pronto-v3-pil'
compatible in the related devicetree documentation ?
(bindings/remoteproc/qcom,wcnss-pil.txt)
Sireesh Kodali March 14, 2023, 6:04 p.m. UTC | #4 
On Tue Mar 14, 2023 at 2:19 PM IST, Loic Poulain wrote:
> On Sat, 11 Mar 2023 at 16:07, Sireesh Kodali <sireeshkodali1@gmail.com> wrote:
> >
> > From: Vladimir Lypak <vladimir.lypak@gmail.com>
> >
> > Pronto v3 has a different DXE address than prior Pronto versions. This
> > patch changes the macro to return the correct register address based on
> > the pronto version.
> >
> > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
>
> Acked-by: Loic Poulain <loic.poulain@linaro.org>
>
> Could you also submit a change for the new 'qcom,pronto-v3-pil'
> compatible in the related devicetree documentation ?
> (bindings/remoteproc/qcom,wcnss-pil.txt)

The changes to the device tree were only recently merged
LKML link: https://lkml.org/lkml/2022/9/30/1502
Loic Poulain March 14, 2023, 6:42 p.m. UTC | #5 
On Tue, 14 Mar 2023 at 19:04, Sireesh Kodali <sireeshkodali1@gmail.com> wrote:
>
> On Tue Mar 14, 2023 at 2:19 PM IST, Loic Poulain wrote:
> > On Sat, 11 Mar 2023 at 16:07, Sireesh Kodali <sireeshkodali1@gmail.com> wrote:
> > >
> > > From: Vladimir Lypak <vladimir.lypak@gmail.com>
> > >
> > > Pronto v3 has a different DXE address than prior Pronto versions. This
> > > patch changes the macro to return the correct register address based on
> > > the pronto version.
> > >
> > > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> > > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
> >
> > Acked-by: Loic Poulain <loic.poulain@linaro.org>
> >
> > Could you also submit a change for the new 'qcom,pronto-v3-pil'
> > compatible in the related devicetree documentation ?
> > (bindings/remoteproc/qcom,wcnss-pil.txt)
>
> The changes to the device tree were only recently merged
> LKML link: https://lkml.org/lkml/2022/9/30/1502

Perfect, thanks.

Loic