| Message ID | 20230309184636.84124-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 0c14f3aa388d3becd38923869e17f9947a5e5926 |
| Headers | show |
| Series | [v1,1/2] gpio: sim: Deactivate device in reversed order | expand |
On Thu, Mar 9, 2023 at 7:46 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Run the steps to deactivate device in the reserved order to what > it has been done in gpio_sim_device_activate_unlocked(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-sim.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c > index e5dfd636c63c..a1c8702f362c 100644 > --- a/drivers/gpio/gpio-sim.c > +++ b/drivers/gpio/gpio-sim.c > @@ -953,9 +953,9 @@ static void gpio_sim_device_deactivate_unlocked(struct gpio_sim_device *dev) > > swnode = dev_fwnode(&dev->pdev->dev); > platform_device_unregister(dev->pdev); > + gpio_sim_remove_hogs(dev); > gpio_sim_remove_swnode_recursive(swnode); > dev->pdev = NULL; > - gpio_sim_remove_hogs(dev); > } > > static ssize_t > -- > 2.39.1 > Meh, doesn't really fix any problem but applied anyway for consistency. Thanks, Bart
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index e5dfd636c63c..a1c8702f362c 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -953,9 +953,9 @@ static void gpio_sim_device_deactivate_unlocked(struct gpio_sim_device *dev) swnode = dev_fwnode(&dev->pdev->dev); platform_device_unregister(dev->pdev); + gpio_sim_remove_hogs(dev); gpio_sim_remove_swnode_recursive(swnode); dev->pdev = NULL; - gpio_sim_remove_hogs(dev); } static ssize_t
Run the steps to deactivate device in the reserved order to what it has been done in gpio_sim_device_activate_unlocked(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)