mbox series

[0/1] wifi: ath9k: Remove Qwest/Actiontec 802AIN ID

Message ID 20230305210245.9831-1-bage@debian.org
Headers show
Series wifi: ath9k: Remove Qwest/Actiontec 802AIN ID | expand

Message

Bastian Germann March 5, 2023, 9:02 p.m. UTC
Drop a wrongly claimed USB ID.

Bastian Germann (1):
  wifi: ath9k: Remove Qwest/Actiontec 802AIN ID

 drivers/net/wireless/ath/ath9k/hif_usb.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Kalle Valo March 6, 2023, 6:19 a.m. UTC | #1
Bastian Germann <bage@debian.org> writes:

> Drop a wrongly claimed USB ID.
>
> Bastian Germann (1):
>   wifi: ath9k: Remove Qwest/Actiontec 802AIN ID
>
>  drivers/net/wireless/ath/ath9k/hif_usb.c | 2 --
>  1 file changed, 2 deletions(-)

I can't find the actual patch anywhere, I only see the cover letter:

https://lore.kernel.org/all/20230305210245.9831-1-bage@debian.org/
Kalle Valo March 6, 2023, 1:07 p.m. UTC | #2
Bastian Germann <bage@debian.org> writes:

> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
> correctly claimed to be supported by carl9170.
>
> Supposedly, the successor 802AIN2 which has an ath9k compatible chip
> whose USB ID (unknown) could be inserted instead.
>
> Drop the ID from the wrong driver.
>
> Signed-off-by: Bastian Germann <bage@debian.org>

Thanks, I see this patch now.

I guess there's a bug report somewhere, do you have a link?
Kalle Valo March 6, 2023, 1:49 p.m. UTC | #3
Bastian Germann <bage@debian.org> writes:

> Am 06.03.23 um 14:07 schrieb Kalle Valo:
>> Bastian Germann <bage@debian.org> writes:
>>
>>> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
>>> correctly claimed to be supported by carl9170.
>>>
>>> Supposedly, the successor 802AIN2 which has an ath9k compatible chip
>>> whose USB ID (unknown) could be inserted instead.
>>>
>>> Drop the ID from the wrong driver.
>>>
>>> Signed-off-by: Bastian Germann <bage@debian.org>
>>
>> Thanks, I see this patch now.
>>
>> I guess there's a bug report somewhere, do you have a link?
>
> No, I happened to find this by chance while packaging the ath9k and
> carl9170 firmware for Debian,
> which have the ID represented in an XML format:
> https://salsa.debian.org/debian/open-ath9k-htc-firmware/-/blob/master/debian/firmware-ath9k-htc.metainfo.xml

Do you mind if we add this (without the link) to the commit log? It's
good to always document the background of the patch.
Toke Høiland-Jørgensen March 6, 2023, 1:59 p.m. UTC | #4
Bastian Germann <bage@debian.org> writes:

> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
> correctly claimed to be supported by carl9170.
>
> Supposedly, the successor 802AIN2 which has an ath9k compatible chip
> whose USB ID (unknown) could be inserted instead.
>
> Drop the ID from the wrong driver.
>
> Signed-off-by: Bastian Germann <bage@debian.org>

Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>