diff mbox series

[1/2] arm64: dts: qcom: sm8450-hdk: use precise WCD9385 compatible

Message ID 20230308183317.559253-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit f0d0966f87f9c38b74619bf7f0345f368af3a4c1
Headers show
Series [1/2] arm64: dts: qcom: sm8450-hdk: use precise WCD9385 compatible | expand

Commit Message

Krzysztof Kozlowski March 8, 2023, 6:33 p.m. UTC
The HDK8450 uses WCD9385 audio codec, so use precise compatible, even
though WCD9380 and WCD9385 are both compatible.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio March 8, 2023, 8:58 p.m. UTC | #1
On 8.03.2023 19:33, Krzysztof Kozlowski wrote:
> Downstream DTS uses 16 mA drive strength for the WCD9385 audio codec
> RESET_N reset pin.  It also pulls the pin down in shutdown mode, thus it
> is more like a shutdown pin, not a reset.  Use the same settings here
> for HDK8450 and keep the WCD9385 by default in powered off (so pin as
> low).  Align the name of pin configuration node with other pins in the
> DTS.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index 9cd1d1bd86cb..4020e54e16f5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -767,9 +767,11 @@ spkr_2_sd_n_active: spkr-2-sd-n-active-state {
>  		output-low;
>  	};
>  
> -	wcd_default: wcd-default-state {
> +	wcd_default: wcd-reset-n-active-state {
>  		pins = "gpio43";
>  		function = "gpio";
> +		drive-strength = <16>;
>  		bias-disable;
> +		output-low;
>  	};
>  };
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index e04de4bb7fae..9cd1d1bd86cb 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -25,7 +25,7 @@  aliases {
 	};
 
 	wcd938x: audio-codec {
-		compatible = "qcom,wcd9380-codec";
+		compatible = "qcom,wcd9385-codec";
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&wcd_default>;