| Message ID | 20230305125917.209262-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: remoteproc: qcom,adsp: bring back firmware-name | expand |
On Sun, Mar 05, 2023 at 01:59:17PM +0100, Krzysztof Kozlowski wrote: > The firmware-name property was moved from common qcom,pas-common.yaml > binding to each device-specific schema, but the qcom,adsp.yaml was not > updated. > > Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > index 643ee787a81f..828dfebaef6a 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > @@ -44,6 +44,10 @@ properties: > maxItems: 1 > description: Reference to the reserved-memory for the Hexagon core > > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string We need to stop redefining the type for 'firmware-name'. I'm adding it to dtschema, so here just put 'maxItems: 1'. Some cases take more than string, so we have to define this as an array. (We obviously didn't learn the name things plural lesson on this one.) Rob
On 08/03/2023 23:48, Rob Herring wrote: > On Sun, Mar 05, 2023 at 01:59:17PM +0100, Krzysztof Kozlowski wrote: >> The firmware-name property was moved from common qcom,pas-common.yaml >> binding to each device-specific schema, but the qcom,adsp.yaml was not >> updated. >> >> Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> index 643ee787a81f..828dfebaef6a 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> @@ -44,6 +44,10 @@ properties: >> maxItems: 1 >> description: Reference to the reserved-memory for the Hexagon core >> >> + firmware-name: >> + $ref: /schemas/types.yaml#/definitions/string > > We need to stop redefining the type for 'firmware-name'. I'm adding it > to dtschema, so here just put 'maxItems: 1'. Oh, yes! But maybe we should add string pattern to "-name" in general? Just like we have for "-names"? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml index 643ee787a81f..828dfebaef6a 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml @@ -44,6 +44,10 @@ properties: maxItems: 1 description: Reference to the reserved-memory for the Hexagon core + firmware-name: + $ref: /schemas/types.yaml#/definitions/string + description: Firmware name for the Hexagon core + required: - compatible
The firmware-name property was moved from common qcom,pas-common.yaml binding to each device-specific schema, but the qcom,adsp.yaml was not updated. Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++ 1 file changed, 4 insertions(+)