diff mbox series

[v4.5,28/29] gdbstub: Build syscall.c once

Message ID 20230303025805.625589-29-richard.henderson@linaro.org
State New
Headers show
Series gdbstub/next: re-organise and split build | expand

Commit Message

Richard Henderson March 3, 2023, 2:58 a.m. UTC 
There is no longer anything target specific.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 gdbstub/syscalls.c  | 5 +----
 gdbstub/meson.build | 3 +--
 2 files changed, 2 insertions(+), 6 deletions(-)

Comments

Philippe Mathieu-Daudé March 3, 2023, 9:45 a.m. UTC | #1 
On 3/3/23 03:58, Richard Henderson wrote:
> There is no longer anything target specific.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   gdbstub/syscalls.c  | 5 +----
>   gdbstub/meson.build | 3 +--
>   2 files changed, 2 insertions(+), 6 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c
index b7d85c41c7..4391d124e2 100644
--- a/gdbstub/syscalls.c
+++ b/gdbstub/syscalls.c
@@ -2,9 +2,7 @@ 
  * GDB Syscall Handling
  *
  * GDB can execute syscalls on the guests behalf, currently used by
- * the various semihosting extensions. As this interfaces with a guest
- * ABI we need to build it per-guest (although in reality its a 32 or
- * 64 bit target_ulong that is the only difference).
+ * the various semihosting extensions.
  *
  * Copyright (c) 2003-2005 Fabrice Bellard
  * Copyright (c) 2023 Linaro Ltd
@@ -13,7 +11,6 @@ 
  */
 
 #include "qemu/osdep.h"
-#include "cpu.h"
 #include "semihosting/semihost.h"
 #include "sysemu/runstate.h"
 #include "gdbstub/user.h"
diff --git a/gdbstub/meson.build b/gdbstub/meson.build
index d679c7ab86..bd5c5cd67d 100644
--- a/gdbstub/meson.build
+++ b/gdbstub/meson.build
@@ -31,8 +31,7 @@  user_ss.add(gdb_user)
 gdb_softmmu = declare_dependency(link_whole: libgdb_softmmu)
 softmmu_ss.add(gdb_softmmu)
 
-# These have to built to the target ABI
-specific_ss.add(files('syscalls.c'))
+common_ss.add(files('syscalls.c'))
 
 # The user-target is specialised by the guest
 specific_ss.add(when: 'CONFIG_USER_ONLY', if_true: files('user-target.c'))