| Message ID | 20230223152757.13606-5-powen.kao@mediatek.com |
|---|---|
| State | New |
| Headers | show |
| Series | Several UFS MCQ Code Changes | expand |
On 23.02.23 4:27 PM, Po-Wen Kao wrote: > is_mcq_supported() already check on use_mcq_mode. > > Signed-off-by: Po-Wen Kao <powen.kao@mediatek.com> > Reviewed-by: Stanley Chu <stanley.chu@mediatek.com> > Reviewed-by: Ziqi Chen <quic_ziqichen@quicinc.com> > --- > drivers/ufs/core/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index 81c9f07ebfc8..3357cfa23616 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -8544,7 +8544,7 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params) > hba->scsi_host_added = true; > } > /* MCQ may be disabled if ufshcd_alloc_mcq() fails */ > - if (is_mcq_supported(hba) && use_mcq_mode) This has been removed/optimized by commit: https://patches.linaro.org/project/linux-scsi/patch/8840cea4a57b46dabce18acc39afc50ab826330f.1676567593.git.quic_asutoshd@quicinc.com/ so this patch is not necessary anymore??? > + if (is_mcq_supported(hba)) > ufshcd_config_mcq(hba); > } >
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 81c9f07ebfc8..3357cfa23616 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -8544,7 +8544,7 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params) hba->scsi_host_added = true; } /* MCQ may be disabled if ufshcd_alloc_mcq() fails */ - if (is_mcq_supported(hba) && use_mcq_mode) + if (is_mcq_supported(hba)) ufshcd_config_mcq(hba); }