diff mbox series

[V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

Message ID 20230203014526.1461386-1-peng.fan@oss.nxp.com
State New
Headers show
Series [V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ | expand

Commit Message

Peng Fan (OSS) Feb. 3, 2023, 1:45 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
compatible.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Rebased on linux-next, remove power-domains from v1

 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Peng Fan Feb. 24, 2023, 4:37 a.m. UTC | #1 
Ping..

> Subject: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> compatible.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V2:
>  Rebased on linux-next, remove power-domains from v1
> 
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index be36956af53b..fefd6610ab45 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -30,11 +30,13 @@ allOf:
> 
>  properties:
>    compatible:
> -    contains:
> -      oneOf:
> -        - const: snps,dwc3
> -        - const: synopsys,dwc3
> -          deprecated: true
> +    oneOf:
> +      - items:
> +          - const: fsl,imx8mq-dwc3
> +          - const: snps,dwc3
> +      - const: snps,dwc3
> +      - const: synopsys,dwc3
> +        deprecated: true
> 
>    reg:
>      maxItems: 1
> --
> 2.37.1
Krzysztof Kozlowski Feb. 24, 2023, 8:34 a.m. UTC | #2 
On 03/02/2023 02:45, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> compatible.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Rob Herring (Arm) March 14, 2023, 6:56 p.m. UTC | #3 
On Fri, Feb 3, 2023 at 5:49 PM Peng Fan <peng.fan@nxp.com> wrote:
>
> Hi Rob,
>
> > Subject: Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ
> >
> >
> > On Fri, 03 Feb 2023 09:45:26 +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> > > compatible.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >
> > > V2:
> > >  Rebased on linux-next, remove power-domains from v1
> > >
> > >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12
> > > +++++++-----
> > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
>
> The error is not related my patch, I could help add rochchip and LSx support later,
> this patch is just for i.MX8MQ.

It is related. You must pass 'make dt_binding_check' without setting
DT_SCHEMA_FILES. Your schema is being applied to the
rockchip,dwc3.yaml example. Most likely you need a custom 'select'
entry to avoid applying to all 'snps,dwc3' compatibles.

Rob
Rob Herring (Arm) March 17, 2023, 10:57 p.m. UTC | #4 
On Tue, Mar 14, 2023 at 1:56 PM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Feb 3, 2023 at 5:49 PM Peng Fan <peng.fan@nxp.com> wrote:
> >
> > Hi Rob,
> >
> > > Subject: Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ
> > >
> > >
> > > On Fri, 03 Feb 2023 09:45:26 +0800, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> > > > compatible.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >
> > > > V2:
> > > >  Rebased on linux-next, remove power-domains from v1
> > > >
> > > >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12
> > > > +++++++-----
> > > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > > >
> > >
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > > dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >
> > > yamllint warnings/errors:
> >
> > The error is not related my patch, I could help add rochchip and LSx support later,
> > this patch is just for i.MX8MQ.
>
> It is related. You must pass 'make dt_binding_check' without setting
> DT_SCHEMA_FILES. Your schema is being applied to the
> rockchip,dwc3.yaml example. Most likely you need a custom 'select'
> entry to avoid applying to all 'snps,dwc3' compatibles.

This is now failing in linux-next. Please send an incremental fix.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index be36956af53b..fefd6610ab45 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -30,11 +30,13 @@  allOf:
 
 properties:
   compatible:
-    contains:
-      oneOf:
-        - const: snps,dwc3
-        - const: synopsys,dwc3
-          deprecated: true
+    oneOf:
+      - items:
+          - const: fsl,imx8mq-dwc3
+          - const: snps,dwc3
+      - const: snps,dwc3
+      - const: synopsys,dwc3
+        deprecated: true
 
   reg:
     maxItems: 1