| Message ID | 20230216124445.836777-1-ilias.apalodimas@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: zynqmp: Add an OP-TEE node to the device tree | expand |
On 2/16/23 13:44, Ilias Apalodimas wrote: > Since the zynqmp boards can run upstream OP-TEE, and having the DT node > present doesn't cause any side effects add it in case someone tries to > load OP-TEE. Then I would expect you will enable it for all boards. It means patch zynqmp.dtsi instead of only one board. > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > arch/arm/dts/zynqmp-sm-k26-revA.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/dts/zynqmp-sm-k26-revA.dts b/arch/arm/dts/zynqmp-sm-k26-revA.dts > index bae24aabdbd1..8f457f1a449c 100644 > --- a/arch/arm/dts/zynqmp-sm-k26-revA.dts > +++ b/arch/arm/dts/zynqmp-sm-k26-revA.dts > @@ -45,6 +45,13 @@ > stdout-path = "serial1:115200n8"; > }; > > + firmware { > + optee: optee { > + compatible = "linaro,optee-tz"; > + method = "smc"; indentation looks weird. Please use only tabs. > + }; > + }; > + > memory@0 { > device_type = "memory"; /* 4GB */ > reg = <0x0 0x0 0x0 0x80000000>, <0x8 0x00000000 0x0 0x80000000>; M
Hi Michal On Thu, 16 Feb 2023 at 14:59, Michal Simek <michal.simek@amd.com> wrote: > > > > On 2/16/23 13:44, Ilias Apalodimas wrote: > > Since the zynqmp boards can run upstream OP-TEE, and having the DT node > > present doesn't cause any side effects add it in case someone tries to > > load OP-TEE. > > Then I would expect you will enable it for all boards. It means patch > zynqmp.dtsi instead of only one board. Sure > > > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > > --- > > arch/arm/dts/zynqmp-sm-k26-revA.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/dts/zynqmp-sm-k26-revA.dts b/arch/arm/dts/zynqmp-sm-k26-revA.dts > > index bae24aabdbd1..8f457f1a449c 100644 > > --- a/arch/arm/dts/zynqmp-sm-k26-revA.dts > > +++ b/arch/arm/dts/zynqmp-sm-k26-revA.dts > > @@ -45,6 +45,13 @@ > > stdout-path = "serial1:115200n8"; > > }; > > > > + firmware { > > + optee: optee { > > + compatible = "linaro,optee-tz"; > > + method = "smc"; > > indentation looks weird. Please use only tabs. Weird, checkpatch didn't complain and I did only use tabs Cheers /Ilias > > > + }; > > + }; > > + > > memory@0 { > > device_type = "memory"; /* 4GB */ > > reg = <0x0 0x0 0x0 0x80000000>, <0x8 0x00000000 0x0 0x80000000>; > > M
diff --git a/arch/arm/dts/zynqmp-sm-k26-revA.dts b/arch/arm/dts/zynqmp-sm-k26-revA.dts index bae24aabdbd1..8f457f1a449c 100644 --- a/arch/arm/dts/zynqmp-sm-k26-revA.dts +++ b/arch/arm/dts/zynqmp-sm-k26-revA.dts @@ -45,6 +45,13 @@ stdout-path = "serial1:115200n8"; }; + firmware { + optee: optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; + memory@0 { device_type = "memory"; /* 4GB */ reg = <0x0 0x0 0x0 0x80000000>, <0x8 0x00000000 0x0 0x80000000>;
Since the zynqmp boards can run upstream OP-TEE, and having the DT node present doesn't cause any side effects add it in case someone tries to load OP-TEE. Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> --- arch/arm/dts/zynqmp-sm-k26-revA.dts | 7 +++++++ 1 file changed, 7 insertions(+)