| Message ID | 20230208173343.37582-1-andriy.shevchenko@linux.intel.com |
|---|---|
| Headers | show |
| Series | gpiolib cleanups | expand |
On Wed, Feb 8, 2023 at 6:34 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > The struct fwnode_handle pointer is used in both branches of ifdeffery, > no need to have a copy of the same in each of them, just make it global. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 2/8/23 11:03 PM, Andy Shevchenko wrote: > From: Linus Walleij <linus.walleij@linaro.org> > > The test driver uses the gpiod consumer API so include the right > <linux/gpio/consumer.h> header. This may cause a problem with > struct of_device_id being implcitly pulled in by the legacy > header <linux/gpio.h> so include <linux/mod_devicetable.h> > explicitly as well. > > While at it, drop explicit moduleparam.h (it's included with module.h) > and sort the headers. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/hte/hte-tegra194-test.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c > index 5d776a185bd6..358d4a10c6a1 100644 > --- a/drivers/hte/hte-tegra194-test.c > +++ b/drivers/hte/hte-tegra194-test.c > @@ -6,14 +6,14 @@ > */ > > #include <linux/err.h> > -#include <linux/module.h> > -#include <linux/moduleparam.h> > +#include <linux/gpio/consumer.h> > +#include <linux/hte.h> > #include <linux/interrupt.h> > -#include <linux/gpio.h> > -#include <linux/timer.h> > +#include <linux/mod_devicetable.h> > +#include <linux/module.h> > #include <linux/platform_device.h> > +#include <linux/timer.h> > #include <linux/workqueue.h> > -#include <linux/hte.h> > > /* > * This sample HTE GPIO test driver demonstrates HTE API usage by enabling Acked-by: Dipen Patel <dipenp@nvidia.com>
On Wed, Feb 8, 2023 at 6:34 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > These are some older patches Arnd did last year, rebased to > linux-next-20230208. On top there are Andy's patches regarding > similar topic. The series starts with Linus Walleij's patches. > > The main goal is to remove some of the legacy bits of the gpiolib > interfaces, where the corner cases are easily avoided or replaced > with gpio descriptor based interfaces. > > The idea is to get an immutable branch and route the whole series > via GPIO tree. > Andy, looks like this series has all the acks it needs but I decided to not send it in the upcoming merge window, I'd prefer it gets some time in next so I'll let it sit until the next release cycle. Bart
On Wed, Feb 15, 2023 at 04:52:29PM +0100, Bartosz Golaszewski wrote: > On Wed, Feb 8, 2023 at 6:34 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > These are some older patches Arnd did last year, rebased to > > linux-next-20230208. On top there are Andy's patches regarding > > similar topic. The series starts with Linus Walleij's patches. > > > > The main goal is to remove some of the legacy bits of the gpiolib > > interfaces, where the corner cases are easily avoided or replaced > > with gpio descriptor based interfaces. > > > > The idea is to get an immutable branch and route the whole series > > via GPIO tree. > > Andy, > > looks like this series has all the acks it needs but I decided to not > send it in the upcoming merge window, I'd prefer it gets some time in > next so I'll let it sit until the next release cycle. Ah, I forgot to mention that this is for the next cycle (v6.4). Hence it's fine. (Moreover it's based on Linux Next, so it will fail compilation in any certain tree except that one.) I will create an immutable branch after v6.3-rc1 is out.
These are some older patches Arnd did last year, rebased to linux-next-20230208. On top there are Andy's patches regarding similar topic. The series starts with Linus Walleij's patches. The main goal is to remove some of the legacy bits of the gpiolib interfaces, where the corner cases are easily avoided or replaced with gpio descriptor based interfaces. The idea is to get an immutable branch and route the whole series via GPIO tree. Changes in v4: - incorporated Linus Walleij's patches - reworked touchscreen patch to have bare minimum changes (Dmitry) - described changes in gpio-aggregator in full (Geert) - addressed compilation errors (LKP) - added tags (Geert, Lee, Vincenzo) Changes in v3: - reworked touchscreen patch in accordance with Dmitry's comments - rebased on the latest Linux Next - added on top Andy's series Changes in v2: - dropped patch 8 after Andy's identical patch was merged - rebase on latest gpio tree - leave unused gpio_cansleep() in place for now - address feedback from Andy Shevchenko Andy Shevchenko (7): gpio: aggregator: Add missing header(s) gpio: reg: Add missing header(s) gpio: regmap: Add missing header(s) gpiolib: Drop unused forward declaration from driver.h gpiolib: Deduplicate forward declarations in consumer.h gpiolib: Group forward declarations in consumer.h gpiolib: Clean up headers Arnd Bergmann (7): gpiolib: remove empty asm/gpio.h files gpiolib: coldfire: remove custom asm/gpio.h gpiolib: remove asm-generic/gpio.h gpiolib: remove gpio_set_debounce() gpiolib: remove legacy gpio_export() gpiolib: split linux/gpio/driver.h out of linux/gpio.h gpiolib: split of_mm_gpio_chip out of linux/of_gpio.h Linus Walleij (4): ARM: orion/gpio: Use the right include ARM: s3c24xx: Use the right include hte: tegra-194: Use proper includes gpiolib: Make the legacy <linux/gpio.h> consumer-only Documentation/admin-guide/gpio/sysfs.rst | 2 +- Documentation/driver-api/gpio/legacy.rst | 23 --- .../zh_CN/driver-api/gpio/legacy.rst | 20 --- Documentation/translations/zh_TW/gpio.txt | 19 --- MAINTAINERS | 1 - arch/arm/Kconfig | 1 - arch/arm/include/asm/gpio.h | 21 --- arch/arm/mach-omap1/irq.c | 1 + arch/arm/mach-omap2/pdata-quirks.c | 9 +- arch/arm/mach-orion5x/board-rd88f5182.c | 1 + arch/arm/mach-s3c/s3c64xx.c | 2 +- arch/arm/mach-sa1100/assabet.c | 1 + arch/arm/plat-orion/gpio.c | 5 +- arch/m68k/Kconfig.cpu | 1 - arch/m68k/include/asm/gpio.h | 95 ----------- arch/m68k/include/asm/mcfgpio.h | 2 +- arch/powerpc/platforms/44x/Kconfig | 1 + arch/powerpc/platforms/4xx/gpio.c | 2 +- arch/powerpc/platforms/8xx/Kconfig | 1 + arch/powerpc/platforms/8xx/cpm1.c | 2 +- arch/powerpc/platforms/Kconfig | 2 + arch/powerpc/sysdev/cpm_common.c | 2 +- arch/sh/Kconfig | 1 - arch/sh/boards/board-magicpanelr2.c | 1 + arch/sh/boards/mach-ap325rxa/setup.c | 7 +- arch/sh/include/asm/gpio.h | 45 ------ drivers/gpio/Kconfig | 19 ++- drivers/gpio/TODO | 15 +- drivers/gpio/gpio-aggregator.c | 9 +- drivers/gpio/gpio-altera.c | 2 +- drivers/gpio/gpio-davinci.c | 2 - drivers/gpio/gpio-mm-lantiq.c | 2 +- drivers/gpio/gpio-mpc5200.c | 2 +- drivers/gpio/gpio-reg.c | 12 +- drivers/gpio/gpio-regmap.c | 12 +- drivers/gpio/gpiolib-acpi.c | 10 +- drivers/gpio/gpiolib-acpi.h | 1 - drivers/gpio/gpiolib-of.c | 9 +- drivers/gpio/gpiolib-of.h | 1 - drivers/gpio/gpiolib-swnode.c | 5 +- drivers/gpio/gpiolib-sysfs.c | 25 ++- drivers/gpio/gpiolib.c | 9 +- drivers/hte/hte-tegra194-test.c | 10 +- drivers/input/touchscreen/ads7846.c | 5 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 10 +- drivers/net/ieee802154/ca8210.c | 3 +- .../broadcom/brcm80211/brcmsmac/led.c | 1 + drivers/pinctrl/core.c | 1 - drivers/soc/fsl/qe/gpio.c | 2 +- include/asm-generic/gpio.h | 147 ------------------ include/linux/gpio.h | 104 ++++++++----- include/linux/gpio/consumer.h | 24 +-- include/linux/gpio/driver.h | 31 +++- .../legacy-of-mm-gpiochip.h} | 33 +--- include/linux/mfd/ucb1x00.h | 1 + include/linux/of_gpio.h | 21 --- 56 files changed, 240 insertions(+), 556 deletions(-) delete mode 100644 arch/arm/include/asm/gpio.h delete mode 100644 arch/m68k/include/asm/gpio.h delete mode 100644 arch/sh/include/asm/gpio.h delete mode 100644 include/asm-generic/gpio.h copy include/linux/{of_gpio.h => gpio/legacy-of-mm-gpiochip.h} (50%)