| Message ID | 20230208183755.2907771-6-vladimir.zapolskiy@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | crypto: qcom-qce: Add YAML bindings & support for newer SoCs | expand |
On 08/02/2023 19:37, Vladimir Zapolskiy wrote: > Change QCE IP version specific compatible to two QCE IP family compatibles > based on SoC name and populate these two IP families with particular SoC > specific IP compatible names, which are known at the moment. > > Keep the old compatible 'qcom,crypto-v5.1' for backward compatibility > of DTB ABI, but mark it as deprecated. > > The change is based on the original one written by Bhupesh Sharma. > > Cc: Bhupesh Sharma <bhupesh.sharma@linaro.org> > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > --- > .../devicetree/bindings/crypto/qcom-qce.yaml | 24 +++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > index 4e00e7925fed..f6f1759a2f6e 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > @@ -15,7 +15,27 @@ description: > > properties: > compatible: > - const: qcom,crypto-v5.1 > + oneOf: > + - const: qcom,crypto-v5.1 > + deprecated: true > + description: Kept only for ABI backward compatibility > + - const: qcom,crypto-v5.4 You should mention in commit msg that you document existing compatible v5.4. Otherwise it looks unrelated/unexplained. Especially adding deprecated compatible is unexpected. > + deprecated: true > + description: Kept only for ABI backward compatibility Best regards, Krzysztof
On 09/02/2023 10:18, Krzysztof Kozlowski wrote: > On 08/02/2023 19:37, Vladimir Zapolskiy wrote: >> Change QCE IP version specific compatible to two QCE IP family compatibles >> based on SoC name and populate these two IP families with particular SoC >> specific IP compatible names, which are known at the moment. >> >> Keep the old compatible 'qcom,crypto-v5.1' for backward compatibility >> of DTB ABI, but mark it as deprecated. >> >> The change is based on the original one written by Bhupesh Sharma. >> >> Cc: Bhupesh Sharma <bhupesh.sharma@linaro.org> >> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> >> --- >> .../devicetree/bindings/crypto/qcom-qce.yaml | 24 +++++++++++++++++-- >> 1 file changed, 22 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> index 4e00e7925fed..f6f1759a2f6e 100644 >> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> @@ -15,7 +15,27 @@ description: >> >> properties: >> compatible: >> - const: qcom,crypto-v5.1 >> + oneOf: >> + - const: qcom,crypto-v5.1 >> + deprecated: true >> + description: Kept only for ABI backward compatibility >> + - const: qcom,crypto-v5.4 > > You should mention in commit msg that you document existing compatible > v5.4. Otherwise it looks unrelated/unexplained. Especially adding > deprecated compatible is unexpected. > With commit msg adjustement for v5.4 compatible: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml index 4e00e7925fed..f6f1759a2f6e 100644 --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml @@ -15,7 +15,27 @@ description: properties: compatible: - const: qcom,crypto-v5.1 + oneOf: + - const: qcom,crypto-v5.1 + deprecated: true + description: Kept only for ABI backward compatibility + - const: qcom,crypto-v5.4 + deprecated: true + description: Kept only for ABI backward compatibility + - items: + - enum: + - qcom,ipq6018-qce + - qcom,ipq8074-qce + - qcom,msm8996-qce + - qcom,sdm845-qce + - const: qcom,ipq4019-qce + - items: + - enum: + - qcom,sm8250-qce + - qcom,sm8350-qce + - qcom,sm8450-qce + - qcom,sm8550-qce + - const: qcom,sm8150-qce reg: maxItems: 1 @@ -70,7 +90,7 @@ examples: - | #include <dt-bindings/clock/qcom,gcc-apq8084.h> crypto-engine@fd45a000 { - compatible = "qcom,crypto-v5.1"; + compatible = "qcom,ipq6018-qce", "qcom,ipq4019-qce"; reg = <0xfd45a000 0x6000>; clocks = <&gcc GCC_CE2_AHB_CLK>, <&gcc GCC_CE2_AXI_CLK>,
Change QCE IP version specific compatible to two QCE IP family compatibles based on SoC name and populate these two IP families with particular SoC specific IP compatible names, which are known at the moment. Keep the old compatible 'qcom,crypto-v5.1' for backward compatibility of DTB ABI, but mark it as deprecated. The change is based on the original one written by Bhupesh Sharma. Cc: Bhupesh Sharma <bhupesh.sharma@linaro.org> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> --- .../devicetree/bindings/crypto/qcom-qce.yaml | 24 +++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)