| Message ID | 20230201153019.269718-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/7] dt-bindings: pinctrl: qcom,msm8226: correct GPIO name pattern | expand |
On Wed, Feb 01, 2023 at 04:30:14PM +0100, Krzysztof Kozlowski wrote: > The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern > and gpio-ranges in the example. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Not sure if people care about Fixes tags for DT schema but this patch definitely Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm") I have no idea what I was thinking when I used 117 instead of 113... Thanks a lot for finding and fixing this! Reviewed-by: Stephan Gerhold <stephan@gerhold.net> > --- > .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > index 449e6e34be61..85082adc1811 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > @@ -63,7 +63,7 @@ $defs: > subnode. > items: > oneOf: > - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" > + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" > - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, > sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1, > qdsd_data2, qdsd_data3 ] > @@ -127,7 +127,7 @@ examples: > interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > - gpio-ranges = <&tlmm 0 0 117>; > + gpio-ranges = <&tlmm 0 0 113>; > interrupt-controller; > #interrupt-cells = <2>; > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml index a29b8a9e1f31..6cb667fa8665 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml @@ -56,7 +56,7 @@ $defs: subnode. items: oneOf: - - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-6])$" + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-6])$" - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data ] minItems: 1 maxItems: 36
The MSM8226 TLMM pin controller has GPIOs 0-116, so correct the pattern to bring back missing 107-109. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)