| Message ID | 20230202104452.299048-3-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pinctrl/ARM/arm64: qcom: correct TLMM gpio-ranges and GPIO pin names | expand |
On Thu, Feb 02, 2023 at 11:44:44AM +0100, Krzysztof Kozlowski wrote: > The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern > and gpio-ranges in the example. > > Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Stephan Gerhold <stephan@gerhold.net> > --- > .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > index 449e6e34be61..85082adc1811 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > @@ -63,7 +63,7 @@ $defs: > subnode. > items: > oneOf: > - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" > + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" > - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, > sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1, > qdsd_data2, qdsd_data3 ] > @@ -127,7 +127,7 @@ examples: > interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > - gpio-ranges = <&tlmm 0 0 117>; > + gpio-ranges = <&tlmm 0 0 113>; I thought 112 was the max? > interrupt-controller; > #interrupt-cells = <2>; > > -- > 2.34.1 >
On Thu, 2 Feb 2023 11:44:44 +0100, Krzysztof Kozlowski wrote: > The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern > and gpio-ranges in the example. > > Applied, thanks! [02/10] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example https://git.kernel.org/krzk/linux-dt/c/87b93dd1fbb23b9bbae461bb2c01f6d93c7524d9 Best regards,
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml index 449e6e34be61..85082adc1811 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml @@ -63,7 +63,7 @@ $defs: subnode. items: oneOf: - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2, qdsd_data3 ] @@ -127,7 +127,7 @@ examples: interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; gpio-controller; #gpio-cells = <2>; - gpio-ranges = <&tlmm 0 0 117>; + gpio-ranges = <&tlmm 0 0 113>; interrupt-controller; #interrupt-cells = <2>;
The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern and gpio-ranges in the example. Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Stephan Gerhold <stephan@gerhold.net> --- .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)