| Message ID | 20230202104452.299048-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | pinctrl/ARM/arm64: qcom: correct TLMM gpio-ranges and GPIO pin names | expand |
On Donnerstag, 2. Februar 2023 11:44:43 CET Krzysztof Kozlowski wrote: > The MSM8226 TLMM pin controller has GPIOs 0-116, so correct the pattern > to bring back missing 107-109. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Luca Weiss <luca@z3ntu.xyz> > --- > .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml index > a29b8a9e1f31..6cb667fa8665 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > @@ -56,7 +56,7 @@ $defs: > subnode. > items: > oneOf: > - - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-6])$" > + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-6])$" > - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, > sdc2_data ] minItems: 1 > maxItems: 36
On Donnerstag, 2. Februar 2023 11:44:51 CET Krzysztof Kozlowski wrote: > Correct the number of GPIOs in TLMM pin controller. > > Fixes: 9fb08c801923 ("arm64: dts: qcom: Add MSM8953 device tree") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Given msm8953 has gpio0 - gpio141, 142 looks correct. Reviewed-by: Luca Weiss <luca@z3ntu.xyz> > --- > arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi > b/arch/arm64/boot/dts/qcom/msm8953.dtsi index 4e17bc9f8167..610f3e3fc0c2 > 100644 > --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi > @@ -399,7 +399,7 @@ tlmm: pinctrl@1000000 { > reg = <0x1000000 0x300000>; > interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > - gpio-ranges = <&tlmm 0 0 155>; > + gpio-ranges = <&tlmm 0 0 142>; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>;
On Thu, Feb 2, 2023 at 11:45 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Changes since v1: > 1. Match the driver's ngpios (so usually include the ufs-reset where > applicable). Several patches were dropped, other rewritten. > 2. Add tags Needless to say I'm a big fan of the series: Acked-by: Linus Walleij <linus.walleij@linaro.org> Will you send me a pull request for the pinctrl things as soon as you feel confident it is finished, and I'll queue it up for v6.3? Yours, Linus Walleij
On Thu, 02 Feb 2023 11:44:43 +0100, Krzysztof Kozlowski wrote: > The MSM8226 TLMM pin controller has GPIOs 0-116, so correct the pattern > to bring back missing 107-109. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 02 Feb 2023 11:44:45 +0100, Krzysztof Kozlowski wrote: > The SM6375 TLMM pin controller has GPIOs 0-155, so narrow the pattern > and gpio-ranges in the example. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 02 Feb 2023 11:44:47 +0100, Krzysztof Kozlowski wrote: > The SDX55 TLMM pin controller has GPIOs 0-107, so narrow the pattern. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
On 02/02/2023 23:28, Linus Walleij wrote: > On Thu, Feb 2, 2023 at 11:45 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > >> Changes since v1: >> 1. Match the driver's ngpios (so usually include the ufs-reset where >> applicable). Several patches were dropped, other rewritten. >> 2. Add tags > > Needless to say I'm a big fan of the series: > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Will you send me a pull request for the pinctrl things as soon as > you feel confident it is finished, and I'll queue it up for v6.3? Sure! Best regards, Krzysztof
On Thu, 2 Feb 2023 11:44:45 +0100, Krzysztof Kozlowski wrote: > The SM6375 TLMM pin controller has GPIOs 0-155, so narrow the pattern > and gpio-ranges in the example. > > Applied, thanks! [03/10] dt-bindings: pinctrl: qcom,sm6375: correct GPIO name pattern and example https://git.kernel.org/krzk/linux-dt/c/a51c1f0244c84e482f1ceb4701c38aaa4b224baf Best regards,
On Thu, 2 Feb 2023 11:44:47 +0100, Krzysztof Kozlowski wrote: > The SDX55 TLMM pin controller has GPIOs 0-107, so narrow the pattern. > > Applied, thanks! [05/10] dt-bindings: pinctrl: qcom,sdx55: correct GPIO name pattern https://git.kernel.org/krzk/linux-dt/c/5c7069712c9be01d1bf9061a7ef5ce78df0af0a5 Best regards,
On Thu, 2 Feb 2023 11:44:42 +0100, Krzysztof Kozlowski wrote: > Changes since v1: > 1. Match the driver's ngpios (so usually include the ufs-reset where > applicable). Several patches were dropped, other rewritten. > 2. Add tags > > Best regards, > Krzysztof > > [...] Applied, thanks! [08/10] ARM: dts: qcom: sdx55: correct TLMM gpio-ranges commit: 2291bbd74f3869fb0400a6f867e2ec6d2620b1c2 Best regards,
Hi, Changes since v1: 1. Match the driver's ngpios (so usually include the ufs-reset where applicable). Several patches were dropped, other rewritten. 2. Add tags Best regards, Krzysztof Krzysztof Kozlowski (10): dt-bindings: pinctrl: qcom,msm8226: correct GPIO name pattern dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example dt-bindings: pinctrl: qcom,sm6375: correct GPIO name pattern and example dt-bindings: pinctrl: qcom,msm8953: correct GPIO name pattern dt-bindings: pinctrl: qcom,sdx55: correct GPIO name pattern dt-bindings: pinctrl: qcom,msm8994: correct number of GPIOs dt-bindings: pinctrl: qcom: correct gpio-ranges in examples ARM: dts: qcom: sdx55: correct TLMM gpio-ranges arm64: dts: qcom: msm8953: correct TLMM gpio-ranges arm64: dts: qcom: sm6115: correct TLMM gpio-ranges .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 2 +- .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++-- .../devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml | 2 +- .../devicetree/bindings/pinctrl/qcom,msm8994-pinctrl.yaml | 6 +++--- .../devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 2 +- .../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 4 ++-- .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 2 +- .../devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml | 2 +- arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm6115.dtsi | 2 +- 11 files changed, 15 insertions(+), 15 deletions(-)