| Message ID | 20230128053504.2099620-1-bhupesh.sharma@linaro.org |
|---|---|
| State | Accepted |
| Commit | 3c7306589dddbcc0ac53ec6b2c3a14875879e20c |
| Headers | show |
| Series | [1/2] remoteproc: qcom: pas: Add sm6115 remoteprocs | expand |
On 28/01/2023 06:35, Bhupesh Sharma wrote: > Among the subsystems in the Qualcomm sm6115 platform we find > audio, compute and modem DSPs. > > Add support for controlling these using the peripheral > authentication service (PAS) remoteproc driver. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 28/01/2023 15:20, Rob Herring wrote: > > On Sat, 28 Jan 2023 11:05:04 +0530, Bhupesh Sharma wrote: >> This documents the aDSP, cDSP and MPSS DSPs present >> on the SM6115 SoC. >> >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >> --- >> .../bindings/remoteproc/qcom,sm6115-pas.yaml | 143 ++++++++++++++++++ >> 1 file changed, 143 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/remoteproc/qcom,pas-common.yaml This is expected - the qcom,pas-common.yaml is in remoteproc repo. Best regards, Krzysztof
On 1/28/2023 11:05 AM, Bhupesh Sharma wrote: > Among the subsystems in the Qualcomm sm6115 platform we find > audio, compute and modem DSPs. > > Add support for controlling these using the peripheral > authentication service (PAS) remoteproc driver. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> -Mukesh > --- > drivers/remoteproc/qcom_q6v5_pas.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index 4e1d9b08def4..9eb5a92bf5f6 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -1184,6 +1184,9 @@ static const struct of_device_id adsp_of_match[] = { > { .compatible = "qcom,sdm845-adsp-pas", .data = &sdm845_adsp_resource_init}, > { .compatible = "qcom,sdm845-cdsp-pas", .data = &sdm845_cdsp_resource_init}, > { .compatible = "qcom,sdx55-mpss-pas", .data = &sdx55_mpss_resource}, > + { .compatible = "qcom,sm6115-adsp-pas", .data = &adsp_resource_init}, > + { .compatible = "qcom,sm6115-cdsp-pas", .data = &cdsp_resource_init}, > + { .compatible = "qcom,sm6115-mpss-pas", .data = &sc8180x_mpss_resource}, > { .compatible = "qcom,sm6350-adsp-pas", .data = &sm6350_adsp_resource}, > { .compatible = "qcom,sm6350-cdsp-pas", .data = &sm6350_cdsp_resource}, > { .compatible = "qcom,sm6350-mpss-pas", .data = &mpss_resource_init},
On Sun, Jan 29, 2023 at 12:08:34PM +0100, Krzysztof Kozlowski wrote: > On 28/01/2023 15:20, Rob Herring wrote: > > > > On Sat, 28 Jan 2023 11:05:04 +0530, Bhupesh Sharma wrote: > >> This documents the aDSP, cDSP and MPSS DSPs present > >> on the SM6115 SoC. > >> > >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > >> --- > >> .../bindings/remoteproc/qcom,sm6115-pas.yaml | 143 ++++++++++++++++++ > >> 1 file changed, 143 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > ./Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/remoteproc/qcom,pas-common.yaml > > This is expected - the qcom,pas-common.yaml is in remoteproc repo. Where is that dependency mentioned in this patch? If not mentioned, I will mention it for you with the error report. Rob
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index 4e1d9b08def4..9eb5a92bf5f6 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -1184,6 +1184,9 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,sdm845-adsp-pas", .data = &sdm845_adsp_resource_init}, { .compatible = "qcom,sdm845-cdsp-pas", .data = &sdm845_cdsp_resource_init}, { .compatible = "qcom,sdx55-mpss-pas", .data = &sdx55_mpss_resource}, + { .compatible = "qcom,sm6115-adsp-pas", .data = &adsp_resource_init}, + { .compatible = "qcom,sm6115-cdsp-pas", .data = &cdsp_resource_init}, + { .compatible = "qcom,sm6115-mpss-pas", .data = &sc8180x_mpss_resource}, { .compatible = "qcom,sm6350-adsp-pas", .data = &sm6350_adsp_resource}, { .compatible = "qcom,sm6350-cdsp-pas", .data = &sm6350_cdsp_resource}, { .compatible = "qcom,sm6350-mpss-pas", .data = &mpss_resource_init},
Among the subsystems in the Qualcomm sm6115 platform we find audio, compute and modem DSPs. Add support for controlling these using the peripheral authentication service (PAS) remoteproc driver. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- drivers/remoteproc/qcom_q6v5_pas.c | 3 +++ 1 file changed, 3 insertions(+)