diff mbox series

[v4,1/3] clk: qcom: smd: Add XO RPM clocks for MSM8226/MSM8974

Message ID 20230121192540.9177-2-rayyan@ansari.sh
State Superseded
Headers show
Series [v4,1/3] clk: qcom: smd: Add XO RPM clocks for MSM8226/MSM8974 | expand

Commit Message

Rayyan Ansari Jan. 21, 2023, 7:25 p.m. UTC
Add the XO and XO_A clocks to the MSM8974 clock list, which is also
used on MSM8226.

Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
 drivers/clk/qcom/clk-smd-rpm.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Konrad Dybcio Jan. 23, 2023, 4:50 p.m. UTC | #1
On 21.01.2023 20:25, Rayyan Ansari wrote:
> Add the XO and XO_A clocks to the MSM8974 clock list, which is also
> used on MSM8226.
> 
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/clk/qcom/clk-smd-rpm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index 6f23ca4828f4..31f6de13d156 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -610,6 +610,8 @@ static const struct rpm_smd_clk_desc rpm_clk_msm8936 = {
>  };
>  
>  static struct clk_smd_rpm *msm8974_clks[] = {
> +	[RPM_SMD_XO_CLK_SRC]		= &clk_smd_rpm_branch_bi_tcxo,
> +	[RPM_SMD_XO_A_CLK_SRC]		= &clk_smd_rpm_branch_bi_tcxo_a,
>  	[RPM_SMD_PNOC_CLK]		= &clk_smd_rpm_bus_0_pcnoc_clk,
>  	[RPM_SMD_PNOC_A_CLK]		= &clk_smd_rpm_bus_0_pcnoc_a_clk,
>  	[RPM_SMD_SNOC_CLK]		= &clk_smd_rpm_bus_1_snoc_clk,
Luca Weiss Jan. 27, 2023, 8:18 a.m. UTC | #2
Hi,

Checking clk_summary in debugfs it looks fine on msn8974pro-fairphone-fp2

Tested-by: Luca Weiss <luca@z3ntu.xyz>

Regards
Luca

Konrad Dybcio <konrad.dybcio@linaro.org> schreef op 26 januari 2023 00:33:42 CET:
>
>
>On 26.01.2023 00:00, Stephen Boyd wrote:
>> Quoting Rayyan Ansari (2023-01-25 14:25:08)
>>> On 25/01/2023 20:58, Stephen Boyd wrote:
>>>> Quoting Rayyan Ansari (2023-01-21 11:25:38)
>>>>> Add the XO and XO_A clocks to the MSM8974 clock list, which is also
>>>>> used on MSM8226.
>>>>
>>>> Why was this missing for so long? Does this break suspend? Why are you
>>>> adding it now?
>>>
>>> I am adding it because of a recommendation from a maintainer on an older 
>>> patch version.
>>> See 
>>> https://lore.kernel.org/linux-arm-msm/20230119023337.h6a7f56lizhv4tcy@builder.lan/#t
>> 
>> So nobody has tested this on msm8974? Can you add this information to
>> the commit text?
>
>
>And can it be tested on msm8974?
>+ Luca
>
>^ could you, please?
>
>Konrad
diff mbox series

Patch

diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
index 6f23ca4828f4..31f6de13d156 100644
--- a/drivers/clk/qcom/clk-smd-rpm.c
+++ b/drivers/clk/qcom/clk-smd-rpm.c
@@ -610,6 +610,8 @@  static const struct rpm_smd_clk_desc rpm_clk_msm8936 = {
 };
 
 static struct clk_smd_rpm *msm8974_clks[] = {
+	[RPM_SMD_XO_CLK_SRC]		= &clk_smd_rpm_branch_bi_tcxo,
+	[RPM_SMD_XO_A_CLK_SRC]		= &clk_smd_rpm_branch_bi_tcxo_a,
 	[RPM_SMD_PNOC_CLK]		= &clk_smd_rpm_bus_0_pcnoc_clk,
 	[RPM_SMD_PNOC_A_CLK]		= &clk_smd_rpm_bus_0_pcnoc_a_clk,
 	[RPM_SMD_SNOC_CLK]		= &clk_smd_rpm_bus_1_snoc_clk,